Use webp for avatar storage (ccgo variant) #24661
Closed
+70
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses the git.sr.ht/~jackmordaunt/go-libwebp package to encode avatars as webp. Ref go-gitea#24263 Close go-gitea#24642 Signed-off-by: Andrew Thornton <art27@cantab.net>
GiteaBot
added
the
lgtm/need 2
|
It's an Experimental package from its README. So I think we cannot merge this at the moment. |
|
and it looks like it doesn't compile or pass CI - I'll update the branch to see if it passes CI one more time and if not I think I'll have to close this PR and say that this is not going to be an option. |
|
yup it doesn't compile properly so I think we can say that this is definitively not an option. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the git.sr.ht/~jackmordaunt/go-libwebp package to encode avatars as webp.
Ref #24263
Close #24642