Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have "make" create the executable in root dir #247

Merged
merged 1 commit into from
Nov 30, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 24, 2016

Same as "go build".
Makes it functional by default as it'd then find template/ and public/
by default w/out setting GITEA_WORK_DIR

@andreynering andreynering added topic/deployment type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Nov 24, 2016
@tboerger
Copy link
Member

No, you only want to update the build task, not the release stuff.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 25, 2016
@strk
Copy link
Member Author

strk commented Nov 25, 2016 via email

@strk
Copy link
Member Author

strk commented Nov 25, 2016 via email

@tboerger
Copy link
Member

Now release is entirely broken...

@strk
Copy link
Member Author

strk commented Nov 25, 2016 via email

@strk
Copy link
Member Author

strk commented Nov 25, 2016

After downloading the docker image required for "make release" I don't see what problem make release has which makes you call it broken, could you be more specific about what's broken ?

@tboerger
Copy link
Member

release-copy and latest-copy can't work anymore

@strk
Copy link
Member Author

strk commented Nov 25, 2016

Should be fixed with ee7b6e2

@tboerger
Copy link
Member

Ok, do everything in the root dir but make sure that all make tasks stay working and drop bin from gitignore. The release part should be moved entirely to the dist folder

@strk
Copy link
Member Author

strk commented Nov 27, 2016

You asked me to not touch the release part, it's untouched now, no ? Don't have time to go back and forth, feel free to file a new PR the way you want if not planning to merge this.

@bkcsoft
Copy link
Member

bkcsoft commented Nov 29, 2016

@strk if you give me permission to, I can push the requested fix to your branch 🙂

@strk
Copy link
Member Author

strk commented Nov 29, 2016

@bkcsoft sounds like it would require too much GUI Web browser interaction, how about you give me an url to your published branch and I merge it ? :)

@lunny
Copy link
Member

lunny commented Nov 30, 2016

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 30, 2016
Same as "go build".
Makes it functional by default as it'd then find template/ and public/
by default w/out setting GITEA_WORK_DIR
@tboerger
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2016
@lunny lunny merged commit a3fb627 into go-gitea:master Nov 30, 2016
@strk strk deleted the build-in-root branch December 2, 2016 11:05
ethantkoenig added a commit to ethantkoenig/gitea that referenced this pull request Jan 27, 2018
* Restore accidentally-removed Google Analytics JS

* Empty commit to rerun CI
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants