Fix video width overflow in markdown, and other changes to match img #24834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the CSS for <video> in markup match that of <img>, and also allows additional attributes to be used. This way the width, padding, alignment should work equally well for both.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
brechtvl
changed the title
wxiaoguang
approved these changes
May 21, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
May 21, 2023
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
May 21, 2023
* main: Rewrite logger system (go-gitea#24726) Support Copy Link for video attachments (go-gitea#24833) Fix video width overflow in markdown, and other changes to match img (go-gitea#24834) Improve accessibility when (re-)viewing files (go-gitea#24817)
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 22, 2023
* giteaofficial/main: (27 commits) Fix regression: access log template, gitea manager cli command (go-gitea#24838) Merge message template support for rebase without merge commit (go-gitea#22669) [skip ci] Updated licenses and gitignores Support wildcard in email domain allow/block list (go-gitea#24831) Change `--font-weight-bold` to `--font-weight-semibold` and 600 value, introduce new font weight variables (go-gitea#24827) Rewrite logger system (go-gitea#24726) Support Copy Link for video attachments (go-gitea#24833) Fix video width overflow in markdown, and other changes to match img (go-gitea#24834) Improve accessibility when (re-)viewing files (go-gitea#24817) Refactor rename user and rename organization (go-gitea#24052) Use `CommentList` instead of `[]*Comment` (go-gitea#24828) Fix topics deleted via API not being deleted in org page (go-gitea#24825) Return `404` in the API if the requested webhooks were not found (go-gitea#24823) Decouple the different contexts from each other (go-gitea#24786) [skip ci] Updated translations via Crowdin Add RTL rendering support to Markdown (go-gitea#24816) [skip ci] Updated translations via Crowdin Update JS dependencies (go-gitea#24815) Fix duplicate tooltip hiding (go-gitea#24814) Mute repo names in dashboard repo list (go-gitea#24811) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the CSS for
<video>in markup match that of<img>, and also allows additional attributes to be used. This way the width, padding, alignment should work equally well for both.