-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dropdown menus, remove inline styles #24954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 27, 2023
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
May 27, 2023
silverwind
added
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
May 27, 2023
delvh
approved these changes
May 27, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 27, 2023
Yeah I had the same feeling, they are pretty pointless in general, also in the reaction dropdown. |
pull-request-size
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
May 27, 2023
Ok I have removed all titles from issue sidebar dropdowns now. There are a few remaining cases where title is still used for "No Items", I guess I'll leave those as-is. |
delvh
approved these changes
May 27, 2023
wxiaoguang
reviewed
May 28, 2023
pull-request-size
bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
May 28, 2023
pull-request-size
bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
May 28, 2023
silverwind
changed the title
Remove a few inline styles
Improve dropdown menus, remove inline styles
May 28, 2023
wxiaoguang
approved these changes
May 29, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 29, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 29, 2023
@silverwind please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 29, 2023
* origin/main: Hide 'Mirror Settings' when unneeded, improve hints (go-gitea#24433) Consolidate the two review boxes into one (go-gitea#24738)
silverwind
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 29, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 29, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 30, 2023
* upstream/main: Remove unnecessary content on docs (go-gitea#24976) Upgrade snap to node 20 (go-gitea#24990) Display file mode for new file and file mode changes (go-gitea#24966) Enable `vue/html-closing-bracket-spacing` eslint rule (go-gitea#24987) Fix repo level project - edit column (go-gitea#24982) Add v3.18 to TestPackageAlpine (go-gitea#24972) Fix admin config page error, use tests to cover the admin config and 500 error page (go-gitea#24965) Improve dropdown menus, remove inline styles (go-gitea#24954) Unify doc links to use paths relative to doc folder (go-gitea#24979) Rework button coloring, add focus and active colors (go-gitea#24507) Add PDF rendering via PDFObject (go-gitea#24086) Hide 'Mirror Settings' when unneeded, improve hints (go-gitea#24433) Consolidate the two review boxes into one (go-gitea#24738) API endpoint for changing/creating/deleting multiple files (go-gitea#24887) Repo list improvements, fix bold helper classes (go-gitea#24935) Add step start time to `ViewStepLog` (go-gitea#24980) Update from-binary.en-us.md (go-gitea#24975)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: