Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge new project templates into one #24985

Merged
merged 9 commits into from
May 31, 2023

Conversation

delvh
Copy link
Member

@delvh delvh commented May 29, 2023

Additionally simplify the new project template slightly.

Review hint: Disable whitespace changes.

Before

New repo project

grafik

Edit repo project

grafik

New user/org project

grafik

Edit user/org project

grafik

After

New repo project

grafik

Edit repo project

grafik

New user/org project

grafik

Edit user/org project

grafik

Additionally simplify the "new project" template slightly
@delvh delvh added topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality. labels May 29, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2023
@delvh delvh marked this pull request as draft May 29, 2023 12:32
@delvh delvh changed the title Merge new project templates into one WIP: Merge new project templates into one May 29, 2023
@delvh delvh changed the title WIP: Merge new project templates into one Merge new project templates into one May 29, 2023
@delvh delvh marked this pull request as ready for review May 29, 2023 12:35
routers/web/org/projects.go Outdated Show resolved Hide resolved
@delvh
Copy link
Member Author

delvh commented May 29, 2023

@lunny @silverwind all done.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 29, 2023
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 29, 2023
@delvh
Copy link
Member Author

delvh commented May 29, 2023

😲 I just noticed I can remove a lot of dead code.
Commit incoming!

@silverwind
Copy link
Member

😲 I just noticed I can remove a lot of dead code. Commit incoming!

image

@delvh
Copy link
Member Author

delvh commented May 29, 2023

According to my quick calculation, this PR reduces Giteas binary and RAM size by roughly 11.4kb (deletions) - 4.6kb (additions) = 6.8kb (savings) 🎉

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 31, 2023
@silverwind silverwind merged commit bf27fc3 into go-gitea:main May 31, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 31, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 31, 2023
@delvh delvh deleted the refactor/merge-new-project-templates branch May 31, 2023 08:38
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 1, 2023
* upstream/main:
  Fix users cannot visit issue attachment bug (go-gitea#25019)
  Fix incorrect issuel filter menu style (go-gitea#25018)
  Update repo's default branch when adding new files in an empty one (go-gitea#25017)
  Rename NotifyPullReviewRequest to NotifyPullRequestReviewRequest (go-gitea#24988)
  Merge `new project` templates into one (go-gitea#24985)
  Add chinese documentations for `cran package registry` (go-gitea#25012)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants