Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing reference prefix of commits when sync mirror repository #24994

Merged
merged 1 commit into from
May 30, 2023
Merged

Fix missing reference prefix of commits when sync mirror repository #24994

merged 1 commit into from
May 30, 2023

Conversation

sillyguodong
Copy link
Contributor

@sillyguodong sillyguodong commented May 30, 2023 •
edited
Loading

replace #24868
just a patch to fix #24824 in v1.19.4
The reference name of commits when synchronizing should also has prefix like refs/heads/.

@GiteaBot GiteaBot added this to the 1.19.4 milestone May 30, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2023
@sillyguodong sillyguodong mentioned this pull request May 30, 2023
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 30, 2023
@lunny lunny added type/bug reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 30, 2023
@lunny lunny merged commit 826b7b9 into go-gitea:release/v1.19 May 30, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 30, 2023
@dboreham
Copy link

Thanks, confirmed as fixing the issue with manual testing of today's gitea/gitea:1.19-nightly container image.

@dboreham dboreham mentioned this pull request May 30, 2023
Closed
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 3, 2023
@sillyguodong @earl-warren
Fix missing reference prefix of commits when sync mirror repository (g…
58bdcae 
…o-gitea#24994)

replace go-gitea#24868
just a patch to fix go-gitea#24824 in v1.19.4
The reference name of commits when synchronizing should also has prefix
like refs/heads/<branch-name>.

(cherry picked from commit 826b7b9)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 28, 2023
@sillyguodong sillyguodong deleted the bugfix/issue_24824_back_to_1.19 branch February 29, 2024 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.
5 participants
@sillyguodong @dboreham @lunny @wxiaoguang @GiteaBot