Skip to content

Avoid creation of deprecated LFS_CONTENT_PATH setting #25148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Avoid creation of deprecated LFS_CONTENT_PATH setting #25148

wants to merge 1 commit into from

Conversation

earl-warren
Copy link
Contributor

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 8, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2023
@wxiaoguang
Copy link
Contributor

But the question is: why the deprecated option should be kept? It should have been removed in 1.19.

@lunny lunny mentioned this pull request Jun 13, 2023
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2023
@techknowlogick techknowlogick changed the title [GITEA] avoid creation of deprecated LFS_CONTENT_PATH setting Avoid creation of deprecated LFS_CONTENT_PATH setting Jun 13, 2023
@wxiaoguang
Copy link
Contributor

But the question is: why the deprecated option should be kept? It should have been removed in 1.19.

To answer this question: it's done in

Use a fatal error to remind users to fix their config.

@lunny
Copy link
Member

lunny commented Jun 14, 2023

Replaced by #23911

@lunny lunny closed this Jun 14, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@earl-warren @wxiaoguang @lunny @silverwind @GiteaBot