Fix task list checkbox toggle to work with YAML front matter (#25184) #25225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a#25184) Fixes go-gitea#25160. `data-source-position` of checkboxes in a task list was incorrect whenever there was YAML front matter. This would result in issue content or PR descriptions getting corrupted with random `x` or space characters when a user checked or unchecked a task.
GiteaBot
added
type/bug
outdated/theme/markdown
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
approved these changes
Jun 13, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Jun 13, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
unit test failure is related. @jtran |
lunny
removed
the
reviewed/wait-merge
silverwind
added
reviewed/wait-merge
|
Needs this change on 1.19 only. Apply with |
|
I made a new PR with the fix: #25236. |
auto-merge was automatically disabled
June 13, 2023 16:29
Pull request was closed
silverwind
pushed a commit
that referenced
this pull request
Jun 13, 2023
…#25236) Backport #25184 by @jtran Closes #25225. Fixes #25160. `data-source-position` of checkboxes in a task list was incorrect whenever there was YAML front matter. This would result in issue content or PR descriptions getting corrupted with random `x` or space characters when a user checked or unchecked a task.
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this pull request
Jun 23, 2023
…a#25184) (go-gitea#25236) Backport go-gitea#25184 by @jtran Closes go-gitea#25225. Fixes go-gitea#25160. `data-source-position` of checkboxes in a task list was incorrect whenever there was YAML front matter. This would result in issue content or PR descriptions getting corrupted with random `x` or space characters when a user checked or unchecked a task. (cherry picked from commit 1650a26)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #25184 by @jtran
Fixes #25160.
data-source-positionof checkboxes in a task list was incorrect whenever there was YAML front matter. This would result in issue content or PR descriptions getting corrupted with randomxor space characters when a user checked or unchecked a task.