Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show 'Manage Account Links' when necessary #25311

Merged
merged 5 commits into from
Jun 24, 2023

Conversation

n0toose
Copy link
Contributor

@n0toose n0toose commented Jun 16, 2023

If it is not possible to add or manage an account link, the menu
will not be shown to the user.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 16, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2023
@n0toose
Copy link
Contributor Author

n0toose commented Jun 16, 2023

FYI: This change wasn't tested thoroughly; I did not add any OAuth providers to test whether the menu will appear in that case. I believe that it should work as I took advantage of a preexisting condition, but there's a chance that I may be incorrect.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 24, 2023
@lunny lunny enabled auto-merge (squash) June 24, 2023 12:34
@lunny lunny merged commit 5eeddfd into go-gitea:main Jun 24, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 24, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 24, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 22, 2023
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants