-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue filter #25335
Fixing issue filter #25335
Conversation
This is a very complex style issue to fix. But I have tried my best to cover all the screen sizes, specially mobile view and viewport < 1024px . Obviosly there are some tricks and hacks I have used. I know there may be some changes which not looks great in terms of coding style. I am open for all the feedbacks and suggestions to make the screen great. Please take the pull of this branch and run at the local while reviewing. Code may looks great but keeping ui screen on side by side will give extra points to consider why this style used. |
I think we could also just make those wrap instead. Horizontal scrollbars are suboptimal UX on mobile, and I would also like to eventually get rid of the one on the repo tab bar. |
Sure thing, |
@wxiaoguang |
Thank you for inviting me for reviewing, and thank you for your contribution 🙏 . I am pretty busy on this one ( Overall I think I am neutral to these changes, while I am not sure whether different languages would also affect the layout. I might take a look later but I can't promise because I am going be in travel in the following weeks. |
No worries, whenever required I am available for making changes and discussion to taking this in right direct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits and questions
This PR seems to break the changes introduced in #25315 by removing used CSS classes.... |
I can not say right now on the break changes. But I have gone through that PR. I am making changing cautiously so that they will not effect others. |
I think I have a slightly cleaner fix for it, will push it later |
Shall I close this PR. Since alternate PR #25368 looks nicer. |
Fix #24846 applying the solution proposed by @silverwind <details> <summary>Screenshots</summary> ![Bildschirmfoto vom 2023-06-19 12-20-54](https://github.com/go-gitea/gitea/assets/47871822/3f4e4536-38c4-451b-bfc0-a7c39acd37f0) ![Bildschirmfoto vom 2023-06-19 12-21-02](https://github.com/go-gitea/gitea/assets/47871822/3403ecc2-4d7f-4acd-b0c0-1b7a10228ff7) ![Bildschirmfoto vom 2023-06-19 12-21-16](https://github.com/go-gitea/gitea/assets/47871822/ef28a2bf-b7cc-4aec-b54b-99d2cc46a1f6) ![Bildschirmfoto vom 2023-06-19 12-21-21](https://github.com/go-gitea/gitea/assets/47871822/f8cd72a5-379e-410b-b0ef-d58895719370) ![Bildschirmfoto vom 2023-06-19 12-21-28](https://github.com/go-gitea/gitea/assets/47871822/34c78301-820c-4106-a086-ae81dc97eb91) ![Bildschirmfoto vom 2023-06-19 12-21-48](https://github.com/go-gitea/gitea/assets/47871822/b677adf1-3a48-42c8-befe-fa9d2679f0a3) </details> Replaces #25335
Fix go-gitea#24846 applying the solution proposed by @silverwind <details> <summary>Screenshots</summary> ![Bildschirmfoto vom 2023-06-19 12-20-54](https://github.com/go-gitea/gitea/assets/47871822/3f4e4536-38c4-451b-bfc0-a7c39acd37f0) ![Bildschirmfoto vom 2023-06-19 12-21-02](https://github.com/go-gitea/gitea/assets/47871822/3403ecc2-4d7f-4acd-b0c0-1b7a10228ff7) ![Bildschirmfoto vom 2023-06-19 12-21-16](https://github.com/go-gitea/gitea/assets/47871822/ef28a2bf-b7cc-4aec-b54b-99d2cc46a1f6) ![Bildschirmfoto vom 2023-06-19 12-21-21](https://github.com/go-gitea/gitea/assets/47871822/f8cd72a5-379e-410b-b0ef-d58895719370) ![Bildschirmfoto vom 2023-06-19 12-21-28](https://github.com/go-gitea/gitea/assets/47871822/34c78301-820c-4106-a086-ae81dc97eb91) ![Bildschirmfoto vom 2023-06-19 12-21-48](https://github.com/go-gitea/gitea/assets/47871822/b677adf1-3a48-42c8-befe-fa9d2679f0a3) </details> Replaces go-gitea#25335
Backport #25368 by @denyskon Fix #24846 applying the solution proposed by @silverwind <details> <summary>Screenshots</summary> ![Bildschirmfoto vom 2023-06-19 12-20-54](https://github.com/go-gitea/gitea/assets/47871822/3f4e4536-38c4-451b-bfc0-a7c39acd37f0) ![Bildschirmfoto vom 2023-06-19 12-21-02](https://github.com/go-gitea/gitea/assets/47871822/3403ecc2-4d7f-4acd-b0c0-1b7a10228ff7) ![Bildschirmfoto vom 2023-06-19 12-21-16](https://github.com/go-gitea/gitea/assets/47871822/ef28a2bf-b7cc-4aec-b54b-99d2cc46a1f6) ![Bildschirmfoto vom 2023-06-19 12-21-21](https://github.com/go-gitea/gitea/assets/47871822/f8cd72a5-379e-410b-b0ef-d58895719370) ![Bildschirmfoto vom 2023-06-19 12-21-28](https://github.com/go-gitea/gitea/assets/47871822/34c78301-820c-4106-a086-ae81dc97eb91) ![Bildschirmfoto vom 2023-06-19 12-21-48](https://github.com/go-gitea/gitea/assets/47871822/b677adf1-3a48-42c8-befe-fa9d2679f0a3) </details> Replaces #25335 Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
In current version of Gitea we have problems with mobile viewport.
Current Mobile screen:
After Modification Mobile Screen [Main Modification]:
Dropdowns:
Ultra Large Devices:
Large Devices:
Devices less than 1024 and grater than mobile screen:
Fixes #24846