-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add releases/latest{file} route #25429
Conversation
|
I don't think
|
I know, that currently you can't download through |
I didn't do that because the download route seems to be subject to different auth checks and I don't understand enough about the routing library to know if that would be problematic. But if you think it's ok, it's fine with me. |
Pushed a commit that changes the path to Now looking at how to add a test... |
I found existing tests here: https://github.com/go-gitea/gitea/blob/main/tests/integration/api_releases_test.go but doesn't look like there is a test for download already. I will look at adding one for the existing download, and the latest release download code added in this PR. |
Should we expose the new link on UI somewhere? |
I'm not sure. GH just documents this (search for "Linking to the latest release"). |
A test would be nice, likely in |
Closing because this PR has already been merged. It seems to achieve roughly the same goal, except presumably will cause problems if anyone ever makes a real tag named "latest". This PR handled that case by using a distinct route rather than overloading the meaning of the vTag. |
Possible partial fix (the "download url for latest release" part) for #3712
Draft PR posted for comment, tests currently missing.