Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content holes in Actions task logs file (#25560) #25566

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Fix content holes in Actions task logs file (#25560) #25566

merged 2 commits into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. Fix content holes in Actions task logs file (go-gitea#25560) 

    Fix go-gitea#25451.

Bugfixes:
- When stopping the zombie or endless tasks, set `LogInStorage` to true
after transferring the file to storage. It was missing, it could write
to a nonexistent file in DBFS because `LogInStorage` was false.
- Always update `ActionTask.Updated` when there's a new state reported
by the runner, even if there's no change. This is to avoid the task
being judged as a zombie task.

Enhancement:
- Support `Stat()` for DBFS file.
- `WriteLogs` refuses to write if it could result in content holes.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
    @wolfogre @GiteaBot
    wolfogre and GiteaBot committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    92eaf25 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/v1.20' into backport-25560-v1.20

    @GiteaBot
    GiteaBot authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e3aa236 View commit details
    Browse the repository at this point in the history