Do not overwrite the SSH_DOMAIN when installing #25580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
wxiaoguang
added
backport/v1.20
lunny
approved these changes
Jun 29, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Jun 29, 2023
| @@ -390,7 +390,7 @@ func SubmitInstall(ctx *context.Context) { | |||
| cfg.Section("database").Key("LOG_SQL").SetValue("false") // LOG_SQL is rarely helpful | |||
|
|
|||
| cfg.Section("repository").Key("ROOT").SetValue(form.RepoRootPath) | |||
| cfg.Section("server").Key("SSH_DOMAIN").SetValue(form.Domain) | |||
| cfg.Section("server").Key("SSH_DOMAIN").MustString(form.Domain) | |||
There was a problem hiding this comment.
Are we really going to convert each SetValue to MustString in a separate PR now?
There was a problem hiding this comment.
Do you have a better idea for this PR?
Put into draft, let's think more about it ....
There was a problem hiding this comment.
That wasn't meant as disapproval, I've simply noticed a tendency lately to replace SetValue in this method with MustString.
I'm wondering how many other settings we will convert as well in subsequent PRs.
GiteaBot
added
lgtm/done
|
I have a clear idea about this problem now. Make "install page" respect environment config #25648 |
silverwind
pushed a commit
that referenced
this pull request
Jul 9, 2023
Replace #25580 Fix #19453 The problem was: when users set "GITEA__XXX__YYY" , the "install page" doesn't respect it. So, to make the result consistent and avoid surprising end users, now the "install page" also writes the environment variables to the config file. And, to make things clear, there are enough messages on the UI to tell users what will happen. There are some necessary/related changes to `environment-to-ini.go`: * The "--clear" flag is removed and it was incorrectly written there. The "clear" operation should be done if INSTALL_LOCK=true * The "--prefix" flag is removed because it's never used, never documented and it only causes inconsistent behavior. 
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Jul 10, 2023
Replace go-gitea#25580 Fix go-gitea#19453 The problem was: when users set "GITEA__XXX__YYY" , the "install page" doesn't respect it. So, to make the result consistent and avoid surprising end users, now the "install page" also writes the environment variables to the config file. And, to make things clear, there are enough messages on the UI to tell users what will happen. There are some necessary/related changes to `environment-to-ini.go`: * The "--clear" flag is removed and it was incorrectly written there. The "clear" operation should be done if INSTALL_LOCK=true * The "--prefix" flag is removed because it's never used, never documented and it only causes inconsistent behavior.  # Conflicts: # templates/install.tmpl
KN4CK3R
pushed a commit
that referenced
this pull request
Jul 10, 2023
Backport #25648 Replace #25580 Fix #19453 The problem was: when users set "GITEA__XXX__YYY" , the "install page" doesn't respect it. So, to make the result consistent and avoid surprising end users, now the "install page" also writes the environment variables to the config file. And, to make things clear, there are enough messages on the UI to tell users what will happen. There are some necessary/related changes to `environment-to-ini.go`: * The "--clear" flag is removed and it was incorrectly written there. The "clear" operation should be done if INSTALL_LOCK=true * The "--prefix" flag is removed because it's never used, never documented and it only causes inconsistent behavior. The only conflict during backport is "ui divider" in templates/install.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
Close #19453
SSH_DOMAINvariable when set as an environment variable #19453