Convert branch table name column to a new collation for mysql/mssql to support case sensitive because branch names are case sensitive #25623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o support case sensitive because branch names are case sensitive
lunny
added
type/bug
skip-changelog
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
reviewed
Jul 2, 2023
| } | ||
| } else if setting.Database.Type.IsMSSQL() { | ||
| return []*schemas.Collation{ | ||
| {Name: "Latin1_General_CS_AS", Column: "name"}, |
There was a problem hiding this comment.
IIRC SQLServer doesn't treat this collation as UTF-8 internally.
So it's better to add a test for it to make sure wide UTF-8 chars (eg: emoji) can be inserted and selected correctly.
|
Reference to #25909 added. |
|
Might be good to add a test of a repo migration when case-differing branch name, e.g. |
Merged
|
-> Make table column branch.name case sensitive #28633 |
|
replaced by #28633 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git branch names are case sensitive. Since #22743 introduced branch name in database and mysql/mssql default collation are case insensitive, this PR converts the column to a case sensitive collation.
Fixes: #25909