Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog for v1.19.4 #25667

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Changelog for v1.19.4 #25667

merged 5 commits into from
Jul 4, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 4, 2023

No description provided.

@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 4, 2023
@6543 6543 added this to the 1.19.4 milestone Jul 4, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 4, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2023
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 4, 2023
wxiaoguang
wxiaoguang reviewed Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
wxiaoguang
wxiaoguang reviewed Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jul 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Jul 4, 2023

@wxiaoguang we should emcourage the usage of 'skip-changelog' lable more!!!

@6543 6543 requested a review from a team July 4, 2023 11:05
@silverwind
Copy link
Member

silverwind commented Jul 4, 2023 •
edited
Loading

I'd say most changes are not notable and we could remove skip-changelog and rely solely on the changelog label to explicitely flag PRs for changelog. Still, both variants require a certain discipline.

@wxiaoguang
Copy link
Contributor

@wxiaoguang we should emcourage the usage of 'skip-changelog' lable more!!!

My proposal is to treat all "docs" changes as "skip-changelog", because the docs are not a part of each release .....

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 4, 2023
@silverwind
Copy link
Member

silverwind commented Jul 4, 2023 •
edited
Loading

My proposal is to treat all "docs" changes as "skip-changelog", because the docs are not a part of each release .....

Could be semi-automated through the bot setting labels based on modified files. But it needs a "only" type of match, e.g. if only docs is modified, set skip-changelog. Ideally this should be a config file in the .github directory.

.github/giteabot.yaml:

autolabels:
  only:
    - glob: docs/**
      labels: [kind/docs, skip-changelog]
  any:
    - glob: Makefile
      labels: [build]

cc: @yardenshoham

Edit: GiteaBot/gitea-backporter#93

@6543
Copy link
Member Author

6543 commented Jul 4, 2023

isn't https://github.com/go-gitea/gitea/blob/main/.changelog.yml what we already have ?!?

@silverwind
Copy link
Member

isn't https://github.com/go-gitea/gitea/blob/main/.changelog.yml what we already have ?!?

That's just for changelog generation. What I'm talking about is auto-adding labels on PRs based on modified files.

@6543 6543 enabled auto-merge (squash) July 4, 2023 12:55
@6543 6543 merged commit d424357 into go-gitea:release/v1.19 Jul 4, 2023
@6543 6543 deleted the changelog_v1.19.4 branch July 4, 2023 16:37
@silverwind silverwind mentioned this pull request Jul 4, 2023
Closed
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jul 5, 2023
@6543
Changelog for v1.19.4 (go-gitea#25667)
12cbbc5 
(cherry picked from commit d424357)
@6543 6543 added frontport/main This PR is not targeting the main branch. Still, its changes should also be added there frontport/done The frontport PR has been created labels Jul 5, 2023
6543 added a commit to 6543-forks/gitea that referenced this pull request Jul 5, 2023
@6543
Changelog for v1.19.4 (go-gitea#25667)
65197a8
@6543 6543 mentioned this pull request Jul 5, 2023
Merged
6543 added a commit that referenced this pull request Jul 5, 2023
@6543
Changelog for v1.19.4 (#25667) (#25709)
c0edb9b 
frontport  #25667
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 6, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3f41e38 
* giteaofficial/main:
  Disable run user change in installation page (go-gitea#22499)
  [skip ci] Updated translations via Crowdin
  Show correct naming for 1 comment (go-gitea#25704)
  Check `ctx.Written()` for `GetActionIssue` (go-gitea#25698)
  Changelog for v1.19.4 (go-gitea#25667) (go-gitea#25709)
  Remove `feature` label from `feature request` issue template (go-gitea#25696)
  Fix tags header and pretty format numbers (go-gitea#25624)
  Fix position of org follow button (go-gitea#25688)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
frontport/done The frontport PR has been created frontport/main This PR is not targeting the main branch. Still, its changes should also be added there lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @silverwind @wxiaoguang @lunny @GiteaBot