Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate image loading #25675

Merged
merged 5 commits into from
Jul 4, 2023
+2 −1
Merged

Prevent duplicate image loading #25675

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9fca9c
Prevent duplicate image loading
delvh Jul 4, 2023
7d05819
Fix lint
delvh Jul 4, 2023
08b8bf1
Rename `data-is-loaded-image` -> `data-is-image-loaded`
delvh Jul 4, 2023
ee6911c
Next rename
delvh Jul 4, 2023
e9b8c09
Merge branch 'main' into bugfix/no-duplicate-image-loading
GiteaBot Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename data-is-loaded-image -> data-is-image-loaded
@delvh
delvh committed Jul 4, 2023

Verified

This commit was signed with the committer’s verified signature.
delvh
GPG key ID: 3DECE05F6D9A647C
Verified
Learn about vigilant mode
commit 08b8bf17dca8a94914d7e081852a6aa612f80449
4 changes: 2 additions & 2 deletions web_src/js/features/imagediff.js
View file
Original file line number Diff line number Diff line change
@@ -65,9 +65,9 @@ export function initImageDiff() {
};
}

$('.image-diff:not([data-is-loaded-image])').each(function() {
$('.image-diff:not([data-is-image-loaded])').each(function() {
const $container = $(this);
$container.attr('data-is-loaded-image', 'true');
$container.attr('data-is-image-loaded', 'true');

// the container may be hidden by "viewed" checkbox, so use the parent's width for reference
const diffContainerWidth = Math.max($container.closest('.diff-file-box').width() - 300, 100);