Fix org admin can not access org project unit #25691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
puni9869
reviewed
Jul 26, 2023
models/migrations/v1_21/v268.go
Outdated
Comment on lines
32
to
48
| AccessModeRead = 1 | ||
| // AccessModeAdmin admin access | ||
| AccessModeAdmin = 3 | ||
|
|
||
| // Unit Type | ||
| TypeInvalid UnitType = iota // 0 invalid | ||
| TypeCode // 1 code | ||
| TypeIssues // 2 issues | ||
| TypePullRequests // 3 PRs | ||
| TypeReleases // 4 Releases | ||
| TypeWiki // 5 Wiki | ||
| TypeExternalWiki // 6 ExternalWiki | ||
| TypeExternalTracker // 7 ExternalTracker | ||
| TypeProjects // 8 Kanban board | ||
| TypePackages // 9 Packages | ||
| TypeActions // 10 Actions | ||
| ) |
|
Need someone to review. |
lunny
reviewed
Nov 15, 2023
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
|
Need reviewers. |
lunny
reviewed
Jan 18, 2024
models/migrations/v1_22/v285.go
Outdated
|
|
||
| // find all admin teams | ||
| teams := make([]*Team, 0) | ||
| err := sess.Where("team.authorize = ?", AccessModeAdmin).Find(&teams) |
There was a problem hiding this comment.
It may consume much memory for a big instance.
This was referenced Nov 5, 2024
Draft
lunny
reviewed
Nov 5, 2024
| } | ||
|
|
||
| if existingUnitTypes.Contains(u) { | ||
| sess.Cols("access_mode").Update(newTeamUnit) |
There was a problem hiding this comment.
returned error haven't been handlered.
lunny
reviewed
Nov 5, 2024
| if existingUnitTypes.Contains(u) { | ||
| sess.Cols("access_mode").Update(newTeamUnit) | ||
| } else { | ||
| sess.Insert(newTeamUnit) |
lunny
reviewed
Nov 5, 2024
| } | ||
| } | ||
|
|
||
| return sess.Commit() |
There was a problem hiding this comment.
You need to detect whether there are still records haven't been committed. Some database will fail if submit a zero change commit.
|
@lunny |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25670
We should backport the logic fix to 1.19 and 1.20
DB migration is only for 1.21