-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newly pushed branches hints on repository home page #25715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
label
Jul 6, 2023
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 6, 2023
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Jul 6, 2023
lunny
changed the title
WIP: Newly pushed branches hint
Newly pushed branches hints on repository home page
Jul 6, 2023
wxiaoguang
reviewed
Jul 6, 2023
wxiaoguang
reviewed
Jul 6, 2023
<div class="ui positive message gt-p-4 gt-df gt-ac gt-tl"> | ||
<div class="gt-f1"> | ||
{{$timeSince := TimeSince .UpdatedUnix.AsTime $.locale}} | ||
{{$.locale.Tr "repo.pulls.recently_pushed_new_branches" $.Repository.OwnerName $.Repository.LowerName .Name $timeSince | Safe}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the .Name
can't be Safe
because it comes from git repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
kolaente
reviewed
Jul 6, 2023
delvh
reviewed
Jul 6, 2023
delvh
approved these changes
Jul 6, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jul 6, 2023
wolfogre
reviewed
Jul 7, 2023
wolfogre
approved these changes
Jul 7, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jul 7, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 7, 2023
wxiaoguang
reviewed
Jul 7, 2023
…o lunny/new_branch_pr_hint
wxiaoguang
approved these changes
Jul 7, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 8, 2023
5 tasks
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 10, 2023
* giteaofficial/main: (31 commits) Fix WORK_DIR for docker (root) image (go-gitea#25738) Avoid amending the Rebase and Fast-forward merge if there is no message template (go-gitea#25779) Show edit title button on commits tab of PR, too (go-gitea#25791) Make "install page" respect environment config (go-gitea#25648) Enable H014 and H023 djlint rules (go-gitea#25786) Restructure issue list template, styles (go-gitea#25750) Fix notification list bugs (go-gitea#25781) Revert package access change from go-gitea#23879 (go-gitea#25707) Make route middleware/handler mockable (go-gitea#25766) Update tool dependencies, lock govulncheck and actionlint (go-gitea#25655) Test if container blob is accessible before mounting (go-gitea#22759) Always pass 6-digit hex color to monaco (go-gitea#25780) Fix the wrong default branch name displayed by checkout (go-gitea#25777) Tweak repo topics bar (go-gitea#25769) docs: rootless docker ssh's default port is 2222 (go-gitea#25771) Repository Archived text title center align (go-gitea#25767) Update JS dependencies, misc tweaks (go-gitea#25768) Clarify "text-align" CSS helpers, fix clone button padding (go-gitea#25763) Switch to `vite-string-plugin` (go-gitea#25762) Newly pushed branches hints on repository home page (go-gitea#25715) ...
wxiaoguang
added a commit
that referenced
this pull request
Aug 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will display a pull request creation hint on the repository home page when there are newly created branches with no pull request. Only the recent 6 hours and 2 updated branches will be displayed.
Inspired by #14003
Replace #14003
Resolves #311
Resolves #13196
Resolves #23743
co-authored by @kolaente
screenshots