Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the LFS GC logger usage #25717

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Simplify the LFS GC logger usage #25717

merged 4 commits into from
Jul 6, 2023

Conversation

wxiaoguang
Copy link
Contributor

Remove unnecessary if opts.Logger != nil checks.

  • For "CLI doctor" mode, output to the console's "logger.Info".
  • For "Web Task" mode, output to the default "logger.Debug", to avoid flooding the server's log in a busy production instance.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 6, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 6, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Jul 6, 2023
@techknowlogick techknowlogick changed the title Simplify the LFC GC logger usage Simplify the LFS GC logger usage Jul 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 6, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 6, 2023
@yardenshoham
Copy link
Member

https://github.com/go-gitea/gitea/labels/kind%2Frefactor?

@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 6, 2023
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 6, 2023
@silverwind silverwind enabled auto-merge (squash) July 6, 2023 15:11
@silverwind silverwind merged commit f0bde0e into go-gitea:main Jul 6, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 6, 2023
@wxiaoguang wxiaoguang deleted the improve-lfs-gc-log branch July 6, 2023 16:59
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 7, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
55bdbdd 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Remove unused code (go-gitea#25734)
  Fix commits table regression (go-gitea#25710)
  Fix inconsistent user profile layout across tabs (go-gitea#25625)
  Simplify the LFS GC logger usage (go-gitea#25717)
  Allow/fix review (approve/reject) of empty PRs (go-gitea#25690)
  Correct permissions for `.ssh` and `authorized_keys` (go-gitea#25721)
  Sync branches when mirroring (go-gitea#25722)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@denyskon denyskon denyskon approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
7 participants
@wxiaoguang @yardenshoham @lunny @denyskon @delvh @silverwind @GiteaBot