Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin on the new/edit milestone page #25801

Merged
merged 13 commits into from
Jul 12, 2023
Merged

Fix margin on the new/edit milestone page #25801

Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
75ce14b
Fixing the new/edit milestone page for desktop and mobile ui
puni9869 Jul 10, 2023
c767605
Merge branch 'main' into punit/Fixing-new-and-edit-milestone-page-ui
puni9869 Jul 10, 2023
adb743c
Linter and formatter
puni9869 Jul 10, 2023
25760b3
Linter and formatter
puni9869 Jul 10, 2023
c879d3e
Merge branch 'main' into punit/Fixing-new-and-edit-milestone-page-ui
puni9869 Jul 10, 2023
99a8878
Update templates/repo/issue/milestone_new.tmpl
puni9869 Jul 10, 2023
558a82e
Removing unused style
puni9869 Jul 10, 2023
73d1f8d
Changing the actions buttons to aligns right
puni9869 Jul 11, 2023
9d01ac0
Merge branch 'main' into punit/Fixing-new-and-edit-milestone-page-ui
puni9869 Jul 11, 2023
c8d750f
Merge branch 'main' into punit/Fixing-new-and-edit-milestone-page-ui
GiteaBot Jul 11, 2023
d6cc5bc
Merge branch 'main' into punit/Fixing-new-and-edit-milestone-page-ui
GiteaBot Jul 11, 2023
3c0bbed
Merge branch 'main' into punit/Fixing-new-and-edit-milestone-page-ui
GiteaBot Jul 12, 2023
c5f707f
Merge branch 'main' into punit/Fixing-new-and-edit-milestone-page-ui
GiteaBot Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions templates/repo/issue/milestone_new.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
{{end}}
</h2>
{{template "base/alert" .}}
<form class="ui form grid" action="{{.Link}}" method="post">
<form class="ui form" action="{{.Link}}" method="post">
{{.CsrfTokenHtml}}
<div class="twelve wide column">
<div class="field {{if .Err_Title}}error{{end}}">
<label>{{.locale.Tr "repo.milestones.title"}}</label>
<input name="title" placeholder="{{.locale.Tr "repo.milestones.title"}}" value="{{.title}}" autofocus required maxlength="50">
Expand All @@ -39,23 +38,20 @@
<label>{{.locale.Tr "repo.milestones.desc"}}</label>
<textarea name="content">{{.content}}</textarea>
</div>
</div>
<div class="ui container">
<div class="divider"></div>
<div class="ui right">
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs "gt-text-right", and make the button order as "Cancel" "Submit".

Because, all other Gitea's UI use such layout, it's better to keep consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

{{if .PageIsEditMilestone}}
<a class="ui primary basic button" href="{{.RepoLink}}/milestones">
{{.locale.Tr "repo.milestones.cancel"}}
</a>
<button class="ui green button">
{{.locale.Tr "repo.milestones.modify"}}
</button>
<a class="ui primary basic button" href="{{.RepoLink}}/milestones">
{{.locale.Tr "repo.milestones.cancel"}}
</a>
{{else}}
<button class="ui green button">
{{.locale.Tr "repo.milestones.create"}}
</button>
{{end}}
</div>
</div>
</form>
</div>
Expand Down