Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid opening/closing PRs which are already merged (#25883) #25902

Closed
wants to merge 1 commit into from
Closed

Avoid opening/closing PRs which are already merged (#25883) #25902

wants to merge 1 commit into from

Conversation

GiteaBot
Copy link
Collaborator

Backport #25883 by @yp05327

We can select PRs to open/close them by one click, but we forgot to check whether it is merged.
You can get an opening merged PR:
image

You can confirm this in:
https://try.gitea.io/yp05327/testrepo/pulls/5

@yp05327 @GiteaBot
Avoid opening/closing PRs which are already merged (go-gitea#25883)
b4ee3a9 
We can select PRs to open/close them by one click, but we forgot to
check whether it is merged.
You can get an opening merged PR:

![image](https://github.com/go-gitea/gitea/assets/18380374/22c2e747-4bb9-4742-a9aa-ef39d5308bc5)

You can confirm this in:
https://try.gitea.io/yp05327/testrepo/pulls/5
@GiteaBot GiteaBot added this to the 1.19.5 milestone Jul 15, 2023
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug labels Jul 15, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2023
@GiteaBot GiteaBot requested review from delvh, lunny and silverwind July 15, 2023 22:11
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 15, 2023
@lunny
Copy link
Member

lunny commented Jul 16, 2023

@yp05327 CI failure is related.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 17, 2023
@yp05327
Copy link
Contributor

yp05327 commented Jul 20, 2023

@yp05327 CI failure is related.

@lunny
This fix is based on #25468.
Is it possible to backport #25468 into 1.19?

@lunny
Copy link
Member

lunny commented Jul 21, 2023

Could you rewrite this PR? Since that is a refactor, I don't think it's necessary to backport #25468

@silverwind
Copy link
Member

silverwind commented Jul 21, 2023 •
edited
Loading

FYI, 1.19 CI and/or Drone is generally broken.

@yp05327 yp05327 mentioned this pull request Jul 25, 2023
Merged
@yp05327
Copy link
Contributor

yp05327 commented Jul 25, 2023

Could you rewrite this PR? Since that is a refactor, I don't think it's necessary to backport #25468

Rewrite in #26108

@lunny lunny closed this Jul 25, 2023
@GiteaBot GiteaBot removed this from the 1.19.5 milestone Jul 25, 2023
@techknowlogick techknowlogick deleted the backport-25883-v1.19 branch September 9, 2023 05:29
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees

@yp05327 yp05327

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GiteaBot @lunny @yp05327 @silverwind @delvh