-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI for release tag page / wiki page / subscription page #25948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 18, 2023
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Jul 18, 2023
puni9869
changed the title
Punit/fix UI
Fixing Ui for release tag page / wiki page / subscription page.
Jul 18, 2023
Note:- Please take the pull of this branch for better understanding and then go through the ui changes. |
silverwind
reviewed
Jul 18, 2023
delvh
changed the title
Fixing Ui for release tag page / wiki page / subscription page.
Fix UI for release tag page / wiki page / subscription page
Jul 21, 2023
delvh
approved these changes
Jul 21, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jul 21, 2023
Needs one more 🪄 approval |
silverwind
approved these changes
Jul 25, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jul 25, 2023
silverwind
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 25, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 25, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 26, 2023
* giteaofficial/main: (21 commits) Only show newly pushed branches message in the same repository (go-gitea#26148) Docusaurus-ify (go-gitea#26051) Display deprecated warning in admin panel pages as well as in the log file (go-gitea#26094) Remove "misc" scope check from public API endpoints (go-gitea#26134) Fix LFS object list style (go-gitea#26133) Drop the correct deleted branch table (go-gitea#26028) Fix CLI allowing creation of access tokens with existing name (go-gitea#26071) Fix incorrect router logger (go-gitea#26137) Increase table cell horizontal padding (go-gitea#26140) Update xorm version (go-gitea#26128) Fix UI for release tag page / wiki page / subscription page (go-gitea#25948) added ssh mirror workaround description (go-gitea#26096) Improve "gitea doctor" sub-command and fix "help" commands (go-gitea#26072) Fix wrong commit status in web ui (go-gitea#26121) remove IsWarning in tmpl (go-gitea#26120) Fix minor capitalization error in string (go-gitea#26100) Improve commit graph alignment and truncating (go-gitea#26112) Fix wrong workflow status when rerun a job in an already finished workflow (go-gitea#26119) Allow Organisations to have a E-Mail (go-gitea#25082) doc sync authentication.md to zh-cn (go-gitea#26117) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agenda:
This PR contains UI fixes for release tag page / wiki page / subscription page.
Here is the list of changes made in this PR.
Release tag page
a. In the New Release page the whole ui got change. Now it is covering in full page page with mobile view port. Description about the release the editor preview now has a min-height. and the check boxes for
Prerelease
and option are left aligned. Couple of divider are added.Subscription page:
a. In the subscription page the ui was distorted in mobile view. Now its fix. Couple of unused styles were removed.
Create Wiki page:-
a. In the page the preview of markdown is now contains a fix min-height so this it will not distorted in desktop view and a divider is added before action buttons. Couple of unused styles were removed.
Before
Release page
Editor
Editor preview
After
Markdown preview change
Wiki page
Before
Preview of mark down.
Footer
After
Preview tab block has min-height
Mobile view
Subscription page
Before
After