Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI for release tag page / wiki page / subscription page #25948

Merged
merged 20 commits into from
Jul 25, 2023

Conversation

puni9869
Copy link
Member

@puni9869 puni9869 commented Jul 18, 2023

Agenda:
This PR contains UI fixes for release tag page / wiki page / subscription page.
Here is the list of changes made in this PR.

  1. Release tag page
    a. In the New Release page the whole ui got change. Now it is covering in full page page with mobile view port. Description about the release the editor preview now has a min-height. and the check boxes for Prerelease and option are left aligned. Couple of divider are added.

  2. Subscription page:
    a. In the subscription page the ui was distorted in mobile view. Now its fix. Couple of unused styles were removed.

  3. Create Wiki page:-
    a. In the page the preview of markdown is now contains a fix min-height so this it will not distorted in desktop view and a divider is added before action buttons. Couple of unused styles were removed.

Before

Release page

image image image image

Editor
image

Editor preview
image

image

After

image image image image image

Markdown preview change
image

Wiki page

Before
image
image

Preview of mark down.
image

Footer
image

After

image image image

Preview tab block has min-height
image

Mobile view
image

image image

Subscription page

Before

image image

After
image

image image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 18, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 18, 2023
@puni9869 puni9869 changed the title Punit/fix UI Fixing Ui for release tag page / wiki page / subscription page. Jul 18, 2023
@puni9869
Copy link
Member Author

Note:- Please take the pull of this branch for better understanding and then go through the ui changes.

@puni9869 puni9869 marked this pull request as ready for review July 18, 2023 07:03
@delvh delvh changed the title Fixing Ui for release tag page / wiki page / subscription page. Fix UI for release tag page / wiki page / subscription page Jul 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 21, 2023
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jul 21, 2023
@lunny lunny added this to the 1.21.0 milestone Jul 21, 2023
@puni9869
Copy link
Member Author

Needs one more 🪄 approval

@lunny lunny requested a review from silverwind July 23, 2023 02:07
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 25, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 25, 2023
@silverwind silverwind enabled auto-merge (squash) July 25, 2023 17:27
@silverwind silverwind merged commit 5a56f96 into go-gitea:main Jul 25, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 25, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 26, 2023
* giteaofficial/main: (21 commits)
  Only show newly pushed branches message in the same repository (go-gitea#26148)
  Docusaurus-ify (go-gitea#26051)
  Display deprecated warning in admin panel pages as well as in the log file (go-gitea#26094)
  Remove "misc" scope check from public API endpoints (go-gitea#26134)
  Fix LFS object list style (go-gitea#26133)
  Drop the correct deleted branch table (go-gitea#26028)
  Fix CLI allowing creation of access tokens with existing name (go-gitea#26071)
  Fix incorrect router logger (go-gitea#26137)
  Increase table cell horizontal padding (go-gitea#26140)
  Update xorm version (go-gitea#26128)
  Fix UI for release tag page / wiki page / subscription page (go-gitea#25948)
  added ssh mirror workaround description (go-gitea#26096)
  Improve "gitea doctor" sub-command and fix "help" commands (go-gitea#26072)
  Fix wrong commit status in web ui (go-gitea#26121)
  remove IsWarning in  tmpl (go-gitea#26120)
  Fix minor capitalization error in string (go-gitea#26100)
  Improve commit graph alignment and truncating (go-gitea#26112)
  Fix wrong workflow status when rerun a job in an already finished workflow (go-gitea#26119)
  Allow Organisations to have a E-Mail (go-gitea#25082)
  doc sync authentication.md to zh-cn (go-gitea#26117)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants