Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSPI auth panic #25955

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Fix SSPI auth panic #25955

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2db2506
fix
wxiaoguang Jul 18, 2023
38a247d
Merge branch 'main' into fix-sspi-auth
GiteaBot Jul 18, 2023
d9825b3
Merge branch 'main' into fix-sspi-auth
GiteaBot Jul 18, 2023
665d4b0
Merge branch 'main' into fix-sspi-auth
GiteaBot Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/auth/sspi_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ func (s *SSPI) Verify(req *http.Request, w http.ResponseWriter, store DataStore,
}
store.GetData()["EnableOpenIDSignIn"] = setting.Service.EnableOpenIDSignIn
store.GetData()["EnableSSPI"] = true
// in this case, the store is Gitea's web Context
// in this case, the Verify function is called in Gitea's web context
// FIXME: it doesn't look good to render the page here, why not redirect?
store.(*gitea_context.Context).HTML(http.StatusUnauthorized, tplSignIn)
gitea_context.GetWebContext(req).HTML(http.StatusUnauthorized, tplSignIn)
return nil, err
}
if outToken != "" {
Expand Down