Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-emphasize issue sidebar buttons #26171

Merged
merged 5 commits into from
Jul 30, 2023
Merged

De-emphasize issue sidebar buttons #26171

merged 5 commits into from
Jul 30, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 26, 2023 •
edited
Loading

I find the colored buttons in the issue sidebar distracting, given that they are not primary actions, I think we can de-colorize them.

Before:
Screenshot 2023-07-26 at 19 42 22
Screenshot 2023-07-26 at 19 43 06
Screenshot 2023-07-26 at 19 44 36:

After:
Screenshot 2023-07-26 at 19 42 04
Screenshot 2023-07-26 at 19 42 51
Screenshot 2023-07-26 at 19 45 15

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 26, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2023
denyskon
denyskon approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on it 👍

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 26, 2023
@delvh
Copy link
Member

delvh commented Jul 26, 2023

If there isn't a visual difference between the Start Timer and Add time button, we should perhaps add an icon to signify what button does what.
That helps for orientation when skimming through the sidebar.

@silverwind
Copy link
Member Author

Indeed, we can add some icons to them.

@silverwind silverwind marked this pull request as draft July 26, 2023 19:56
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jul 28, 2023
@techknowlogick
Copy link
Member

still WIP?

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2023
@silverwind
Copy link
Member Author

silverwind commented Jul 29, 2023 •
edited
Loading

Ready now. Icons added:

Screenshot 2023-07-29 at 13 37 12 Screenshot 2023-07-29 at 13 36 56

Modal form margins and borders fixed:

Screenshot 2023-07-29 at 13 38 19

Links muted:

Screenshot 2023-07-29 at 13 41 02

@silverwind silverwind marked this pull request as ready for review July 29, 2023 11:42
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 30, 2023
@silverwind silverwind enabled auto-merge (squash) July 30, 2023 21:55
@silverwind silverwind merged commit 04d7ced into go-gitea:main Jul 30, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jul 30, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 30, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 31, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
baea445 
* upstream/main: (26 commits)
  Add 'Show on a map' button to Location in profile, fix layout (go-gitea#26214)
  Use shared template for webhook icons (go-gitea#26242)
  Reduce margins on user settings page, introduce `flex-container` (go-gitea#26046)
  Refactor and enhance issue indexer to support both searching, filtering and paging (go-gitea#26012)
  Show image size on view page (go-gitea#25884)
  Fix pull request check list is limited (go-gitea#26179)
  Fix API leaking Usermail if not logged in (go-gitea#25097)
  [skip ci] Updated licenses and gitignores
  Fix typo in metadata (go-gitea#26207)
  Update js and py dependencies (go-gitea#26243)
  De-emphasize issue sidebar buttons (go-gitea#26171)
  Don't autosize textarea in diff view (go-gitea#26233)
  Add `/public/assets` to `.ignore` (go-gitea#26232)
  Fix attachment clipboard copy on insecure origin (go-gitea#26224)
  Fix commit compare style (go-gitea#26209)
  Fix unable to display individual-level project (go-gitea#26198)
  Fix access check for org-level project (go-gitea#26182)
  Fixed incorrect locale references (go-gitea#26218)
  Use calendar icon for `Joined on...` in profiles (go-gitea#26215)
  Add changelog for 1.20.2 (go-gitea#26208)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 approved these changes

@delvh delvh delvh approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @delvh @techknowlogick @denyskon @puni9869 @GiteaBot