Delete issue_service.CreateComment
#26298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
CaiCandong
changed the title
issues_model.CreateComment and issue_service.CreateComment into issues_model.CreateCommentissue_service.CreateComment
lunny
added
the
type/refactoring
wolfogre
approved these changes
Aug 4, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Aug 4, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 6, 2023
* upstream/main: (25 commits) [docs] Add missing backtick in quickstart.zh-cn.md (go-gitea#26349) Fix incorrect CLI exit code and duplicate error message (go-gitea#26346) Improve CLI and messages (go-gitea#26341) Remove backslashed newlines on markdown (go-gitea#26344) Hide `last indexed SHA` when a repo could not be indexed yet (go-gitea#26340) Fix log typo in task.go (go-gitea#26337) Prevent newline errors with Debian packages (go-gitea#26332) Fix the bug when getting files changed for `pull_request_target` event (go-gitea#26320) Refactor backend SVG package and add tests (go-gitea#26335) Fix bug with sqlite load read (go-gitea#26305) Remove commit load branches and tags in wiki repo (go-gitea#26304) Add highlight to selected repos in milestone dashboard (go-gitea#26300) Do not show Profile README when repository is private (go-gitea#26295) Fix incorrect color of selected assignees when create issue (go-gitea#26324) Delete `issue_service.CreateComment` (go-gitea#26298) Make git batch operations use parent context timeout instead of default timeout (go-gitea#26325) Fix typos and grammer problems for actions documentation (go-gitea#26328) Update documentation for 1.21 actions (go-gitea#26317) Fix the wrong derive path (go-gitea#26271) Support getting changed files when commit ID is `EmptySHA` (go-gitea#26290) ...
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
issue_service.CreateCommentadds transaction operations onissues_model.CreateComment, we can merge the two functions and we can avoid calling each other's methods in theserviceslayer.