fix generated source URL on rendered files #26364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The permalink and 'Reference in New issue' URL of an renderable file (those where you can see the source and a rendered version of it, such as markdown) doesn't contain `?display=source`. This leads the issue that the URL doesn't have any effect, as by default the rendered version is shown and thus not the source. - Add `?display=source` to the permalink URL and to 'Reference in New Issue' if it's renderable file. - Add integration testing. Refs: https://codeberg.org/forgejo/forgejo/pulls/1088
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
silverwind
approved these changes
Aug 7, 2023
GiteaBot
added
lgtm/need 1
silverwind
added
backport/v1.20
wxiaoguang
approved these changes
Aug 8, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.20. @earl-warren, please send one manually. 🍵 |
GiteaBot
added
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 9, 2023
* upstream/main: [skip ci] Updated translations via Crowdin fix artifact merging chunks path with correct slash on Windows (go-gitea#26400) Use flex classes in package settings (go-gitea#26314) Improve multiple strings in en-US locale (go-gitea#26213) Refactor "editorconfig" (go-gitea#26391) fix generated source URL on rendered files (go-gitea#26364) Remove unnecessary template helper DisableGravatar (go-gitea#26386)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?display=source. This leads the issue that the URL doesn't have any effect, as by default the rendered version is shown and thus not the source.?display=sourceto the permalink URL and to 'Reference in New Issue' if it's renderable file.Refs: https://codeberg.org/forgejo/forgejo/pulls/1088