Skip to content

Use session when creating user #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2017
Merged

Use session when creating user #2638

merged 2 commits into from
Oct 3, 2017

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Oct 2, 2017

Use session when checking for pre-existing usernames and email addresses, not just when inserting user.

@codecov-io
Copy link

codecov-io commented Oct 2, 2017 •
edited
Loading

Codecov Report

Merging #2638 into master will increase coverage by <.01%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2638      +/-   ##
==========================================
+ Coverage   27.11%   27.12%   +<.01%     
==========================================
  Files          86       86              
  Lines       17062    17064       +2     
==========================================
+ Hits         4627     4629       +2     
  Misses      11757    11757              
  Partials      678      678
Impacted Files Coverage Δ
models/user.go 18.24% <30.76%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cfa5a...b878b37. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 2, 2017
@lafriks
Copy link
Member

lafriks commented Oct 2, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 2, 2017
@sapk
Copy link
Member

sapk commented Oct 2, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 2, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 2, 2017
@lunny lunny added this to the 1.3.0 milestone Oct 2, 2017
@lafriks lafriks merged commit 4b2c8ca into go-gitea:master Oct 3, 2017
@ethantkoenig ethantkoenig deleted the fix/use_session branch October 9, 2017 03:12
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ethantkoenig @codecov-io @lafriks @sapk @lunny @tboerger