make filename accessible in dropzone #26487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In Forgejo you can upload files by drag n dropping them in selective 'zones', these are handled by [dropzone](https://github.com/dropzone/dropzone). While waiting for it to finish uploading, you can see the file's size and name. - The name was conviently placed under the progress bar, so as an file is uploading you couldn't see the filename anymore. - This patch fixes that by simply moving the filename a few pixels down. - Resolves https://codeberg.org/Codeberg/Community/issues/1104 Refs: https://codeberg.org/forgejo/forgejo/pulls/1242 (cherry picked from commit 58d500aafdd2dd5756427376763132cdcc5b608c)
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
earl-warren
force-pushed
the
wip-gitea-dropzone
branch
from
b148c0d
to
22306d2
Compare
delvh
approved these changes
Aug 14, 2023
GiteaBot
added
lgtm/need 1
|
This change is not ideal. For UI alignment, you might need to put the progress bar below the filename, like this. Otherwise there is too much space between the "size" and "filename"
And from the HTML layout perspective, the dropzone also prefers to put the progress bar after details (size+filename):
And the |
|
-> Move dropzone progress bar to bottom to show filename when uploading #26492 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropzone. While waiting for it to finish uploading, you can see the file's size and name.
Refs: https://codeberg.org/forgejo/forgejo/pulls/1242
(cherry picked from commit 58d500aafdd2dd5756427376763132cdcc5b608c)