Skip to content

Fix index column deletion #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2017
Merged

Fix index column deletion #2651

merged 1 commit into from
Oct 4, 2017

Conversation

@Morlinest
Copy link
Member

@Morlinest Morlinest commented Oct 4, 2017

Fixes #2650

@lafriks
Copy link
Member

lafriks commented Oct 4, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 4, 2017
@codecov-io
Copy link

codecov-io commented Oct 4, 2017

Codecov Report

Merging #2651 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2651   +/-   ##
=======================================
  Coverage   27.12%   27.12%           
=======================================
  Files          86       86           
  Lines       17064    17064           
=======================================
  Hits         4629     4629           
  Misses      11757    11757           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2c8ca...4e1f6d7. Read the comment docs.

@daviian
Copy link
Member

daviian commented Oct 4, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2017
@lafriks lafriks merged commit a79af9c into go-gitea:master Oct 4, 2017
@Morlinest Morlinest deleted the fix/repo-unit-migration branch October 4, 2017 11:38
@lafriks lafriks added this to the 1.3.0 milestone Oct 4, 2017
@lunny lunny mentioned this pull request Dec 2, 2017
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Migartion removing index column fails

5 participants

@Morlinest @lafriks @codecov-io @daviian @tboerger