Archive labels UI enhancement

[puni9869]

Followup #26478

Archived labels UI

Added:

• Implemented the structural framework for the user interface to accommodate archived labels.
• Introduced archived labels functionality to the UI, akin to the approach taken for closed milestones or projects. This functionality allows concealing information while retaining it, without resorting to deletion.
• Particularly advantageous for managing outdated labels that are no longer in use, offering a means to preserve them without cluttering the active label set.

Changed:

• Enhanced the Filtered UI page to seamlessly incorporate a list of archived labels.

Outsourced:

• Defer the implementation of specialized handling for archived labels to upcoming pull requests. This step will be undertaken subsequent to the successful merge of this pull request.

Screenshots

---

Part of #25237

[KN4CK3R]

What's the benefit of toggling the hightlight?

[puni9869]

What's the benefit of toggling the hightlight?

Here is discussion
#26502 (comment)

[KN4CK3R]

Ok, but I still think a static archived highlight is all what's needed.

[delvh]

Well, my interpretation was a bit different:
I meant hide archived labels by default, and show them only when the checkbox is toggled.
However, they should always be separated visually to identify them easily.
Not show all labels, and highlight archived ones on checkbox click.

[puni9869]

I meant hide archived labels by default, and show them only when the checkbox is toggled.

I am going to change again on the above basis. 💯

[puni9869]

I want to add highlight for initial release of this feature.

[KN4CK3R]

Why not just sort them to the bottom and add the highlight? Then you don't need extra logic to show them and they don't block the view.

[delvh]

Works too.
Except then we need the extra logic to sort them.

[puni9869]

Why not just sort them to the bottom and add the highlight? Then you don't need extra logic to show them and they don't block the view.

I can managed that with js

[KN4CK3R]

Works too. Except then we need the extra logic to sort them.

The extra logic is "sort by archived date"

[delvh]

Sort primarily by archive date and then by name.
True, that works.

[KN4CK3R]

To keep the archived labels sorted by name too you could do the sorting in Go or sort by if archived date > 0 ? 1 : 0 in sql.

[puni9869]

select id ,name , archived_unix, repo_id from label order by archived_unix, name;

[KN4CK3R]

Keep in mind that the archived labels are only sorted by name because the timestamps are in the correct order.

[puni9869]

Let's scope this PR for Ui changes only. I am sending a back to back Pr for Sorting and Db migration changes [We need to index the archived_unix] column and a separate method I am introducing because the older method is used several places.
Just to avoid the conflicts in result set.

Need approvals/reviews regarding UI changes only.
@delvh
cc/ @KN4CK3R

[delvh]

If we sort them in the next PR, why is the toggle code still there?

It's now a different kind of toggle.

[silverwind]

This yellow highlight bar looks very odd, is it removed in latest versions?

[puni9869]

This yellow highlight bar looks very odd, is it removed in latest versions?

We can change the color. I took it from base.css
Looking for suggestions.

[silverwind]

What does it highlight? Archived state? I guess a small "Archived" label would be equally well suited, and less confusing. Maybe in its own column.

[puni9869]

Follup to #26741

[puni9869]

Closing as of now.