Replace box-shadow for floating dropdown as well
#26581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
silverwind
added
the
skip-changelog
silverwind
changed the title
floating dropdown as well
delvh
approved these changes
Aug 18, 2023
GiteaBot
added
lgtm/need 1
|
It's the faint shadow outside the box that was previously far less pronounced. |
|
I know, I still don't see it 😅 |
|
I immediately notice this on the dropdowns, guess I have an eye for such detail 😄 |
wxiaoguang
approved these changes
Aug 21, 2023
GiteaBot
added
lgtm/done
lunny
added
topic/ui
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 22, 2023
* giteaofficial/main: (21 commits) Update minimum password length requirements (go-gitea#25946) cynkra is covered via oc links now (go-gitea#26641) update config docs url (go-gitea#26640) devpod use go1.21 (go-gitea#26637) Use correct minio error (go-gitea#26634) Remove avatarHTML from template helpers (go-gitea#26598) Add optimistic lock to ActionRun table (go-gitea#26563) Improve the branch selector tab UI (go-gitea#26631) Improve translation of milestone filters (go-gitea#26569) Add `branch_filter` to hooks API endpoints (go-gitea#26599) Replace box-shadow for `floating` dropdown as well (go-gitea#26581) Add link to job details and tooltip to commit status in repo list in dashboard (go-gitea#26326) Ignore the trailing slashes when comparing oauth2 redirect_uri (go-gitea#26597) Update tool dependencies (go-gitea#26607) bump go to 1.21 (go-gitea#26608) Update 1.20.3 changelog (go-gitea#26609) Fix NPM packages name validation (go-gitea#26595) Use "input" event instead of "keyup" event for migration form (go-gitea#26602) Do not use deprecated log config options by default (go-gitea#26592) fix reopen logic for agit flow pull request (go-gitea#26399) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
box-shadowreplacement to thefloatingdropdown variant as well, which was missed in #26469. The Fomantic style has!important, so this has to have too. Also made a tiny adjustment to shadow color on dark theme.