Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate the RSS user feed button #26882

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Relocate the RSS user feed button #26882

merged 2 commits into from
Sep 3, 2023

Conversation

devioa
Copy link
Contributor

@devioa devioa commented Sep 3, 2023

before:
before

after:
after

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 3, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2023
@delvh delvh changed the title Make the position of the RSS Feed button more reasonable and aesthetically pleasing. Relocate the RSS user feed button Sep 3, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 3, 2023
KN4CK3R
KN4CK3R previously requested changes Sep 3, 2023
View reviewed changes
templates/shared/user/profile_big_avatar.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 3, 2023
@devioa devioa closed this Sep 3, 2023
@delvh
Copy link
Member

delvh commented Sep 3, 2023

?

@devioa
Copy link
Contributor Author

devioa commented Sep 3, 2023 •
edited
Loading

?

sorry my bad
actually, this is my first PR on github
I accidentally pressed the wrong button when I was just trying to solve this problem locally
I have fix it now
should I restart this PR now?
or should I start a new PR?
sorry, I'm a novice forgive me

@devioa devioa reopened this Sep 3, 2023
@devioa
Copy link
Contributor Author

devioa commented Sep 3, 2023

alright it should be okay now

@delvh delvh requested a review from KN4CK3R September 3, 2023 10:37
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Sep 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 3, 2023
@KN4CK3R KN4CK3R enabled auto-merge (squash) September 3, 2023 10:38
@KN4CK3R KN4CK3R merged commit 918acca into go-gitea:main Sep 3, 2023
24 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 3, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 4, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
258382e 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Update documents to fix some links (go-gitea#26885)
  clarify aspects of the dump command (go-gitea#26887)
  Relocate the `RSS user feed` button (go-gitea#26882)
  Use Go 1.21 and update dependencies (go-gitea#26878)
  Update docs about attachment path (go-gitea#26883)
  Refactor "shortsha" (go-gitea#26877)
  Fix wrong review requested number (go-gitea#26784)
  Refactor `og:description` to limit the max length (go-gitea#26876)
  Reorder blocks in vue SFCs (go-gitea#26874)
  Make it posible to customize nav text color via css var (go-gitea#26807)
  Enable djlint H008 and fix issues (go-gitea#26869)
  Improve opengraph previews (go-gitea#26851)
  Add more descriptive error on forgot password page (go-gitea#26848)
  Allow users with write permissions for issues to add attachments with API (go-gitea#26837)
  Move licenses.txt to /assets directory (go-gitea#26866)

# Conflicts:
#	templates/base/footer_content.tmpl
@techknowlogick techknowlogick modified the milestones: 1.22.0, 1.21.0 Sep 5, 2023
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Nov 13, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@devioa @delvh @KN4CK3R @techknowlogick @GiteaBot @denyskon