Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about attachment path (#26883) #26884

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

CaiCandong
Copy link
Member

@CaiCandong CaiCandong commented Sep 3, 2023

Backport #26883
This change was caused by #26271, for configuration as below:

[attachment]
ENABLE = true
PATH = data/attachments
MAX_SIZE = 100
MAX_FILES = 5

Before #26271, the resolved path is ${AppWorkPath}/${attachments.PATH} (such as /var/lib/gitea/data/attachments)
After #26271, the resolved path is ${AppDataPath}/${attachments.PATH} (such as /var/lib/gitea/data/data/attachments)

Fix #26864 Follow #26271

This change was caused by go-gitea#26271, for configuration as below:
```
[attachment]
ENABLE = true
PATH = data/attachments
MAX_SIZE = 100
MAX_FILES = 5
```
Before go-gitea#26271, the resolved path is ${AppWorkPath}/${attachments.PATH}
(such as `/var/lib/gitea/data/attachments`)
After go-gitea#26271, the resolved path is ${AppDataPath}/${attachments.PATH}
(such as `/var/lib/gitea/data/data/attachments`)

Fix  go-gitea#26864
Follow go-gitea#26271
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 3, 2023
@GiteaBot GiteaBot added this to the 1.20.4 milestone Sep 3, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 3, 2023
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Sep 3, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) September 3, 2023 18:44
@techknowlogick techknowlogick added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 3, 2023
@techknowlogick techknowlogick merged commit e15794f into go-gitea:release/v1.20 Sep 3, 2023
21 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 3, 2023
@CaiCandong CaiCandong deleted the backport/pr26883 branch September 4, 2023 12:39
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants