Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes for the "commit-body" #26898

Merged
merged 2 commits into from
Sep 4, 2023
Merged

More fixes for the "commit-body" #26898

merged 2 commits into from
Sep 4, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Sep 4, 2023 •
edited
Loading

The changes for "commit-body" in #26877 are not ideal.

The reason is: the "commit-body" is usually a <pre>, it has default margins. In most cases, we do not need that large margin. So, this PR introduces a general but small margin for all "commit-body" elements. Then these gt-m-0 could be removed.

The :not selector is not needed, because the .timeline-item selector is already clear enough.

image

image

@wxiaoguang wxiaoguang added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 4, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Sep 4, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 4, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) September 4, 2023 13:08
@wxiaoguang wxiaoguang merged commit 6825523 into go-gitea:main Sep 4, 2023
23 checks passed
@wxiaoguang wxiaoguang deleted the fix-commit-body-margin branch September 4, 2023 14:17
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 5, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
cefe080 
* giteaofficial/main:
  Move mail notification logic to service layer (go-gitea#26905)
  Improve DeleteByID (go-gitea#26904)
  Update backup instructions to align with archive structure (go-gitea#26902)
  More fixes for the "commit-body" (go-gitea#26898)
  Show queue's active worker number (go-gitea#26896)
  Remove CSS `has` selector and improve various styles (go-gitea#26891)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @delvh @GiteaBot