-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor system setting #27000
Merged
Merged
Refactor system setting #27000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Sep 10, 2023
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Sep 10, 2023
lunny
reviewed
Sep 11, 2023
wxiaoguang
force-pushed
the
refactor-setting
branch
3 times, most recently
from
September 17, 2023 09:42
bd80e39
to
6c6c309
Compare
wxiaoguang
force-pushed
the
refactor-setting
branch
from
September 19, 2023 13:23
45025eb
to
cd961b7
Compare
pull-request-size
bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Sep 19, 2023
wxiaoguang
force-pushed
the
refactor-setting
branch
4 times, most recently
from
September 19, 2023 15:22
850c0e4
to
8014055
Compare
wxiaoguang
force-pushed
the
refactor-setting
branch
from
September 19, 2023 15:52
8014055
to
171af38
Compare
Almost ready for review. |
wxiaoguang
force-pushed
the
refactor-setting
branch
from
September 19, 2023 15:54
171af38
to
55f90e3
Compare
wxiaoguang
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Sep 20, 2023
lunny
approved these changes
Sep 25, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Sep 25, 2023
# Conflicts: # templates/admin/config.tmpl
wolfogre
approved these changes
Oct 4, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 4, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Oct 4, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 5, 2023
This PR reduces the complexity of the system setting system. It only needs one line to introduce a new option, and the option can be used anywhere out-of-box. It is still high-performant (and more performant) because the config values are cached in the config system.
GiteaBot
added
backport/done
All backports for this PR have been created
and removed
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
labels
Oct 5, 2023
lunny
pushed a commit
that referenced
this pull request
Oct 5, 2023
Backport #27000 by @wxiaoguang This PR reduces the complexity of the system setting system. It only needs one line to introduce a new option, and the option can be used anywhere out-of-box. It is still high-performant (and more performant) because the config values are cached in the config system. ![image](https://github.com/go-gitea/gitea/assets/2114189/f8cdd743-1145-41ab-9f8f-3996aa97d440) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
topic/ui
Change the appearance of the Gitea UI
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the complexity of the system setting system.
It only needs one line to introduce a new option, and the option can be used anywhere out-of-box.
It is still high-performant (and more performant) because the config values are cached in the config system.