Remove the useless function GetUserIssueStats and move relevant tests to indexer_test.go
#27067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
lunny
added
the
type/refactoring
lng2020
changed the title
GetIssueStats and move relevant tests to indexer_test.goGetUserIssueStats and move relevant tests to indexer_test.go
KN4CK3R
approved these changes
Sep 14, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Sep 14, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the issue indexer has been refactored, the issue overview webpage is built by the
buildIssueOverviewfunction and underlyingindexer.Searchfunction andGetIssueStatsinstead ofGetUserIssueStats. So the function is no longer used.I moved the relevant tests to
indexer_test.goand since the search option changed fromIssueOptionstoSearchOptions, most of the tests are useless now.We need more tests about the db indexer because those tests are highly connected with the issue overview webpage and now this page has several bugs.
Any advice about those test cases is appreciated.