Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup locale function usage (#27227) #27240

Merged
merged 2 commits into from
Sep 25, 2023
Merged

cleanup locale function usage (#27227) #27240

merged 2 commits into from
Sep 25, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #27227 by @denyskon

Throughout the Gitea codebase, you can meet some weird constructions to make locale.Tr work in subtemplates.
Since we now have ctx.Locale.Tr which solves that problem, clean up various templates which pass locale through dict or use some weird constructions like $.root.locale

Going on, it would be great to replace every case of $.locale.Tr and .locale.Tr with ctx.Locale.Tr, but that needs to be done with patience.

@GiteaBot GiteaBot added type/refactoring Existing code has been cleaned up. There should be no new functionality. topic/ui Change the appearance of the Gitea UI labels Sep 24, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Sep 24, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 24, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 24, 2023
@silverwind silverwind enabled auto-merge (squash) September 24, 2023 23:32
@silverwind silverwind merged commit daaf0ad into go-gitea:release/v1.21 Sep 25, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 25, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees

@denyskon denyskon

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @silverwind @wxiaoguang @denyskon