-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More db.DefaultContext
refactor
#27265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Sep 25, 2023
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Sep 25, 2023
github-actions
bot
added
the
modifies/api
This PR adds API routes or modifies them
label
Sep 25, 2023
JakobDev
changed the title
More db.DefaultContext refactor
More Sep 25, 2023
db.DefaultContext
refactor
delvh
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Sep 25, 2023
delvh
approved these changes
Sep 25, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Sep 25, 2023
|
Done |
lunny
approved these changes
Sep 28, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Sep 28, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Sep 29, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Sep 29, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 29, 2023
Part of go-gitea#27065 This PR touches functions used in templates. As templates are not static typed, errors are harder to find, but I hope I catch it all. I think some tests from other persons do not hurt.
6543
pushed a commit
that referenced
this pull request
Oct 1, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 1, 2023
As title Fix go-gitea#27369 Regression of go-gitea#27265
6543
pushed a commit
that referenced
this pull request
Oct 1, 2023
Backport #27372 by @CaiCandong As title Fix #27369 Regression of #27265 Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com>
This was referenced Oct 4, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 4, 2023
Fix go-gitea#27432 Regression of go-gitea#27265
silverwind
pushed a commit
that referenced
this pull request
Oct 4, 2023
Backport #27434 by @CaiCandong Fix #27432 Regression of #27265 Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/v1.21
This PR should be backported to Gitea 1.21
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/api
This PR adds API routes or modifies them
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27065
This PR touches functions used in templates. As templates are not static typed, errors are harder to find, but I hope I catch it all. I think some tests from other persons do not hurt.