Fix user labels are invisible #27279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Sep 26, 2023
silverwind
approved these changes
Sep 26, 2023
GiteaBot
added
lgtm/need 1
|
It looks strange. I will take a look. |
silverwind
reviewed
Sep 26, 2023
| @@ -35,6 +35,7 @@ export function initGiteaFomantic() { | |||
|
|
|||
| const isIn = arg?.animation?.endsWith(' in'); | |||
| const isOut = arg?.animation?.endsWith(' out'); | |||
| const isScale = arg?.animation?.includes('scale'); | |||
There was a problem hiding this comment.
Maybe startsWith, assuming this is scale in etc.
|
The old code is not right either. According to the Fomantic UI design pattern, the |
|
The code does accept both arg forms, but I do confess this implementation was mostly trial end error. |
|
related(#27286) |
|
-> Fix some animation bugs #27287 The new PR is not "trial end error", while it (almost) strictly follows the Fomantic UI's definition. |
wxiaoguang
added
lgtm/blocked
lunny
pushed a commit
that referenced
this pull request
Sep 27, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 27, 2023
wxiaoguang
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when editing whitelists of protected branch rules in the repo setting, the user labels are invisible.
That's because the transition module is removed and couldn't handle "transition: scale".
This PR adds the code logic to handle this case and fix the bug.