Enable production source maps for index.js, fix CSS sourcemaps #27291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
type/docs
silverwind
added
backport/v1.21
silverwind
force-pushed
the
sourcemap-index
branch
from
cd92641 to
207a88d
Compare
github-actions
bot
added
type/docs
silverwind
force-pushed
the
sourcemap-index
branch
from
207a88d to
e1f22ac
Compare
silverwind
changed the title
silverwind
changed the title
denyskon
approved these changes
Sep 26, 2023
GiteaBot
added
lgtm/need 1
|
Will do a small rework with the env var. |
pull-request-size
bot
added
size/M
lunny
approved these changes
Sep 27, 2023
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
techknowlogick
approved these changes
Sep 27, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 27, 2023
…tea#27291) Previously, the production build never output sourcemaps. Now we emit one file for `index.js` because it is the most likely one where we need to be able to better debug reported issues like go-gitea#27213. This will currently increase the binary size of gitea by around 700kB which is what the gzipped source map file has. Also, I fixed the CSS sourcemap generation which was broken since the introduction of lightningcss.
silverwind
added a commit
that referenced
this pull request
Sep 27, 2023
… (#27295) Backport #27291 by @silverwind Previously, the production build never output sourcemaps. Now we emit one file for `index.js` because it is the most likely one where we need to be able to better debug reported issues like #27213. This will currently increase the binary size of gitea by around 700kB which is what the gzipped source map file has. Also, I fixed the CSS sourcemap generation which was broken since the introduction of lightningcss. The chinese docs are machine-translated, please correct accordingly. Co-authored-by: silverwind <me@silverwind.io>
lunny
added a commit
that referenced
this pull request
Sep 27, 2023
Fix translation from #27291 Source Map will be kept as English in Chinese usage habit.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 28, 2023
* giteaoffical/main: (22 commits) Fix review UI (go-gitea#27322) Improve issue history dialog and make poster can delete their own history (go-gitea#27323) Improve branch list UI (go-gitea#27319) doctor: delete action entries without existing user (go-gitea#27292) fix orphan check for deleted branch (go-gitea#27310) make writing main test easier (go-gitea#27270) [skip ci] Updated translations via Crowdin Fix protected branch icon location (go-gitea#26576) move the `gitea admin` subcommands into separate files (go-gitea#27307) Fix chinese translation (go-gitea#27296) bump bleve (go-gitea#27300) Redefine the meaning of column is_active to make Actions Registration Token generation easier (go-gitea#27143) Use vitest globals (go-gitea#27102) Fix divider in subscription page (go-gitea#27298) Fix yaml test (go-gitea#27297) Enable production source maps for index.js, fix CSS sourcemaps (go-gitea#27291) Fix some animation bugs (go-gitea#27287) Add missed return to actions view fetch (go-gitea#27289) Fix more yaml lint errors (go-gitea#27284) Fix incorrect change from go-gitea#27231 (go-gitea#27275) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the production build never output sourcemaps. Now we emit one file for
index.jsbecause it is the most likely one where we need to be able to better debug reported issues like #27213. This will currently increase the binary size of gitea by around 700kB which is what the gzipped source map file has.Also, I fixed the CSS sourcemap generation which was broken since the introduction of lightningcss.
The chinese docs are machine-translated, please correct accordingly.