Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Index to comment.dependent_issue_id #27325

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Add Index to comment.dependent_issue_id #27325

merged 2 commits into from
Sep 28, 2023

Conversation

JakobDev
Copy link
Contributor

This Column is missing index. It is used by issue_service.deleteIssue.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 28, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 28, 2023
@delvh delvh added performance/speed performance issues with slow downs backport/v1.21 This PR should be backported to Gitea 1.21 labels Sep 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 28, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 28, 2023
@silverwind silverwind merged commit 9d9cebc into go-gitea:main Sep 28, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 28, 2023
@GiteaBot GiteaBot mentioned this pull request Sep 28, 2023
Merged
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Sep 28, 2023
@JakobDev @GiteaBot
Add Index to comment.dependent_issue_id (go-gitea#27325)
0f09323 
This Column is missing index. It is used by
[issue_service.deleteIssue](https://github.com/go-gitea/gitea/blob/7ea2a910cebaf51cfd13c0941029c404e408ae54/services/issue/issue.go#L300).

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 28, 2023
@JakobDev JakobDev deleted the commentindex branch September 28, 2023 21:06
silverwind pushed a commit that referenced this pull request Sep 29, 2023
@GiteaBot @JakobDev
Add Index to comment.dependent_issue_id (#27325) (#27340)
7ea7f2b 
Backport #27325 by @JakobDev

This Column is missing index. It is used by
[issue_service.deleteIssue](https://github.com/go-gitea/gitea/blob/7ea2a910cebaf51cfd13c0941029c404e408ae54/services/issue/issue.go#L300).

Co-authored-by: JakobDev <jakobdev@gmx.de>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JakobDev @silverwind @delvh @GiteaBot