Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make actions default enabled for newly created repository if global configuraion enabled #27482

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Make actions default enabled for newly created repository if global configuraion enabled #27482

merged 4 commits into from
Oct 10, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 6, 2023

Users can still use [repository].DEFAULT_REPO_UNITS= to define the default units.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2023
@github-actions github-actions bot added the type/docs This PR mainly updates/creates documentation label Oct 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 9, 2023
@wxiaoguang
Copy link
Contributor

It seems to be suitable to be backported?

@denyskon
Copy link
Member

denyskon commented Oct 9, 2023

Is it really a good idea? I think that there are more repos that do not need Actions than those that do. Basically the same argument, if your specific instance needs Actions nearly every time, you can enable it through the config - but I'd leave it disabled per default.

@wxiaoguang
Copy link
Contributor

Is it really a good idea? I think that there are more repos that do not need Actions than those that do. Basically the same argument, if your specific instance needs Actions nearly every time, you can enable it through the config - but I'd leave it disabled per default.

IMO the enabled "actions" feature doesn't harm anyone, if you don't use it.

@lunny
Copy link
Member Author

lunny commented Oct 9, 2023 •
edited
Loading

Is it really a good idea? I think that there are more repos that do not need Actions than those that do. Basically the same argument, if your specific instance needs Actions nearly every time, you can enable it through the config - but I'd leave it disabled per default.

But many people do not use projects, pull requests, packages and wiki but those are enabled by default if global configuration enabled, why actions is special?

@lunny lunny changed the title Make actions default enabled for newly created repository Make actions default enabled for newly created repository if global configuraion enabled Oct 9, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 10, 2023
@lunny lunny enabled auto-merge (squash) October 10, 2023 14:02
@lunny lunny merged commit 7ff1f25 into go-gitea:main Oct 10, 2023
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 10, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 10, 2023
@lunny lunny deleted the lunny/make_actions_default branch October 11, 2023 00:23
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 11, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
80cade2 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix attachment download bug (go-gitea#27486)
  Make actions default enabled for newly created repository if global configuraion enabled (go-gitea#27482)
  Fix the wrong HTTP response status code for duplicate packages (go-gitea#27480)
  Increase queue length (go-gitea#27555)
@lunny lunny mentioned this pull request Oct 19, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @wxiaoguang @denyskon @appleboy @a1012112796 @GiteaBot