Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] resolve confusing colors in languages stats by insert a gap #27704

Merged
merged 2 commits into from
Oct 20, 2023
Merged

[FIX] resolve confusing colors in languages stats by insert a gap #27704

merged 2 commits into from
Oct 20, 2023

Conversation

RightFS
Copy link
Contributor

@RightFS RightFS commented Oct 20, 2023 •
edited by wxiaoguang
Loading

The current language stats are too obsessed with color matching. Similar colors are always next to each other. It is a bit troublesome to find the place where the color matching is generated, so just follow the example of github and add a gap.

before

image

after

image

@RightFS
[FIX] resolve confusing colors in languages stats by insert a gap
5e0cab1 
现在的language stats配色太迷, 相近色总是挨在一起, 去找配色生成的地方有点麻烦, 所以直接学github加个gap就好了
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 20, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2023
@lunny lunny requested a review from wxiaoguang October 20, 2023 03:57
wxiaoguang
wxiaoguang approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am neutral for this change.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 20, 2023
@RightFS
Copy link
Contributor Author

RightFS commented Oct 20, 2023

I am neutral for this change.

The other way to fix it is finding the code that generated these colors and add some limitations. But I think this PR is better to everyone especially color-blindness.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2023
@silverwind silverwind added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 20, 2023
@silverwind silverwind mentioned this pull request Oct 20, 2023
Merged
@6543 6543 enabled auto-merge (squash) October 20, 2023 17:26
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 20, 2023
@6543 6543 merged commit 510d075 into go-gitea:main Oct 20, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 20, 2023
@GiteaBot GiteaBot mentioned this pull request Oct 20, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 20, 2023
@RightFS @GiteaBot
[FIX] resolve confusing colors in languages stats by insert a gap (go…
5aa8d5e 
…-gitea#27704)

The current language stats are too obsessed with color matching. Similar
colors are always next to each other. It is a bit troublesome to find
the place where the color matching is generated, so just follow the
example of github and add a gap.

## before

<img width="883" alt="image"
src="https://github.com/go-gitea/gitea/assets/12915306/cf54430c-616c-4b37-b561-5a37c20b2d94">

## after

<img width="877" alt="image"
src="https://github.com/go-gitea/gitea/assets/12915306/e518ea36-2b8f-4f11-a867-a58dc393db85">
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 20, 2023
silverwind pushed a commit that referenced this pull request Oct 20, 2023
@GiteaBot @RightFS
[FIX] resolve confusing colors in languages stats by insert a gap (#2…
993178b 
…7704) (#27715)

Backport #27704 by @RightFS

The current language stats are too obsessed with color matching. Similar
colors are always next to each other. It is a bit troublesome to find
the place where the color matching is generated, so just follow the
example of github and add a gap.

## before

<img width="883" alt="image"
src="https://github.com/go-gitea/gitea/assets/12915306/cf54430c-616c-4b37-b561-5a37c20b2d94">

## after

<img width="877" alt="image"
src="https://github.com/go-gitea/gitea/assets/12915306/e518ea36-2b8f-4f11-a867-a58dc393db85">

Co-authored-by: MrDevil <Right.Sun@outlook.com>
lunny pushed a commit that referenced this pull request Oct 22, 2023
@silverwind
Enable followCursor for language stats bar (#27713)
d8c09c2 
Fixes: #27600


![](https://github.com/go-gitea/gitea/assets/115237/96743d90-0712-4f13-84ec-66f84e6ed2d7)

Also tested together with #27704,
works well.
@GiteaBot GiteaBot mentioned this pull request Oct 22, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 22, 2023
@silverwind @GiteaBot
Enable followCursor for language stats bar (go-gitea#27713)
4c15009 
Fixes: go-gitea#27600


![](https://github.com/go-gitea/gitea/assets/115237/96743d90-0712-4f13-84ec-66f84e6ed2d7)

Also tested together with go-gitea#27704,
works well.
6543 pushed a commit that referenced this pull request Oct 22, 2023
@GiteaBot @silverwind
Enable followCursor for language stats bar (#27713) (#27739)
48e3aec 
Backport #27713 by @silverwind

Fixes: #27600


![](https://github.com/go-gitea/gitea/assets/115237/96743d90-0712-4f13-84ec-66f84e6ed2d7)

Also tested together with #27704,
works well.

Co-authored-by: silverwind <me@silverwind.io>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 23, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
ea65a8c 
* upstream/main:
  Fix incorrect ctx usage in defer function (go-gitea#27740)
  Enable followCursor for language stats bar (go-gitea#27713)
  teams: new View button (go-gitea#27685)
  fix issues in translation file (go-gitea#27699)
  Fix an indentation in the Chinese documentation of Act Runner (go-gitea#27730)
  [skip ci] Updated translations via Crowdin
  Fix org team endpoint (go-gitea#27721)
  Improve diff tree spacing (go-gitea#27714)
  refactor: make db iterate context aware (go-gitea#27710)
  [FIX] resolve confusing colors in languages stats by insert a gap (go-gitea#27704)
  Fix sticky diff header background (go-gitea#27697)
  Replace -1 with GhostUserID (go-gitea#27703)
  Clean some functions about project issue (go-gitea#27705)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@silverwind @fuxiaohei
Enable followCursor for language stats bar (go-gitea#27713)
b4c358a 
Fixes: go-gitea#27600


![](https://github.com/go-gitea/gitea/assets/115237/96743d90-0712-4f13-84ec-66f84e6ed2d7)

Also tested together with go-gitea#27704,
works well.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RightFS @silverwind @wxiaoguang @GiteaBot @6543