Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to members and repositories at teams page #27744

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

Sonic853
Copy link
Contributor

image
The members and repositories text now can be click.

like Org home page:

<a class="muted" href="{{$.OrgLink}}/teams/{{.LowerName | PathEscape}}"><strong>{{.NumMembers}}</strong> {{ctx.Locale.Tr "org.lower_members"}}</a> ·
<a class="muted" href="{{$.OrgLink}}/teams/{{.LowerName | PathEscape}}/repositories"><strong>{{.NumRepos}}</strong> {{ctx.Locale.Tr "org.lower_repositories"}}</a>

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Oct 23, 2023
@puni9869
Copy link
Member

puni9869 commented Oct 24, 2023

Could you test on multiple users what it would looks like.

when number of users are > 1. and what happen when you click on new link.
image

@Sonic853
Copy link
Contributor Author

Could you test on multiple users what it would looks like.

when number of users are > 1. and what happen when you click on new link. image

I created some test users and empty repositories.

Snipaste_2023-10-24_16-01-49

When click "2 members" link, it will jump to the information page of the corresponding team.

Snipaste_2023-10-24_16-02-47

When click "2 repositories" link, it will jump to the corresponding team's repository page.

Snipaste_2023-10-24_16-04-03

@puni9869
Copy link
Member

puni9869 commented Oct 24, 2023

I will give my approval after a bit, I want to hear from other maintainers, what they think. Hope you are okay with that.

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Oct 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 26, 2023
@lunny lunny added this to the 1.22.0 milestone Oct 26, 2023
@lunny lunny enabled auto-merge (squash) October 26, 2023 02:13
@lunny lunny merged commit 4f4ddcf into go-gitea:main Oct 26, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 26, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 26, 2023
* giteaofficial/main:
  Add link to members and repositories at teams page (go-gitea#27744)
  Add dedicated class for empty placeholders (go-gitea#27788)
  Close all hashed buffers (go-gitea#27787)
  Fix typo when updating email address (go-gitea#27789)
  Improve pull request command line instructions (go-gitea#27778)
@Sonic853 Sonic853 deleted the teams-page-link branch October 26, 2023 05:01
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants