Fix duplicate project board when hitting enter key
#27746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lng2020
added
backport/v1.20
delvh
approved these changes
Oct 23, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Oct 23, 2023
| @@ -193,20 +193,6 @@ export function initRepoProject() { | |||
| const url = $(this).data('url'); | |||
| createNewColumn(url, columnTitle, projectColorInput); | |||
| }); | |||
|
|
|||
| $('.new-project-column').on('input keyup', (e) => { | |||
There was a problem hiding this comment.
Why input event is also removed?
There was a problem hiding this comment.
It's not working. The input event is to enable/disable the confirm button. But the confirm button is not disabled at the first place. We don't use this kind of enable/disable attribute in other buttons either. So I removed it.
There was a problem hiding this comment.
The frontend and backend are both introduced in the PR that implements the Project feature. So It has some personal code style. As I said in the description, It would be great if this part of frontend code is refactored to align other POST forms that we used in Gitea.
wxiaoguang
approved these changes
Oct 23, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.20. @lng2020, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 23, 2023
When hitting the `enter` key to create a new project column, the request is sent twice because the `submit` event and `key up` event are both triggered. Probably a better solution is to rewrite these parts of the code to avoid using native jQuery but reuse the `form-fetch-action` class. But it's beyond my ability.
GiteaBot
removed
the
reviewed/wait-merge
lunny
pushed a commit
that referenced
this pull request
Oct 23, 2023
Backport #27746 by @lng2020 When hitting the `enter` key to create a new project column, the request is sent twice because the `submit` event and `key up` event are both triggered. Probably a better solution is to rewrite these parts of the code to avoid using native jQuery but reuse the `form-fetch-action` class. But it's beyond my ability. Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 24, 2023
* giteaofficial/main: Do not force creation of _cargo-index repo on publish (go-gitea#27266) Upgrade to golangci-lint@v1.55.0 (go-gitea#27756) Fix incorrect "tab" parameter for repo search sub-template (go-gitea#27755) Fix label render containing invalid HTML (go-gitea#27752) Fix duplicate project board when hitting `enter` key (go-gitea#27746) Fix `link-action` redirect network error (go-gitea#27734)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
When hitting the `enter` key to create a new project column, the request is sent twice because the `submit` event and `key up` event are both triggered. Probably a better solution is to rewrite these parts of the code to avoid using native jQuery but reuse the `form-fetch-action` class. But it's beyond my ability.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting the
enterkey to create a new project column, the request is sent twice because thesubmitevent andkey upevent are both triggered.Probably a better solution is to rewrite these parts of the code to avoid using native jQuery but reuse the
form-fetch-actionclass. But it's beyond my ability.