-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move reverproxyauth before session so the header will not be ignored even if user has login #27821
Move reverproxyauth before session so the header will not be ignored even if user has login #27821
Conversation
…even if user has login
Isn't that handled by that code? gitea/services/auth/reverseproxy.go Lines 119 to 124 in b36e2ca
|
Not yet. When user hasn't been log out and the reverseproxy send a new user's header. In previous code, Gitea think it has login when checking session and will not check the header any more. |
…even if user has login (go-gitea#27821) When a user logout and then login another user, the reverseproxy auth should be checked before session otherwise the old user is still login.
…even if user has login (go-gitea#27821) When a user logout and then login another user, the reverseproxy auth should be checked before session otherwise the old user is still login.
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix file path width in repo non-homepage view (go-gitea#30951) Enable `declaration-block-no-redundant-longhand-properties` (go-gitea#30950) [skip ci] Updated translations via Crowdin Move reverproxyauth before session so the header will not be ignored even if user has login (go-gitea#27821) Use CSS `inset` shorthand (go-gitea#30939) Remove If Exist check on migration for mssql because that syntax required SQL server 2016 (go-gitea#30894) Update JS dependencies, add new eslint rules (go-gitea#30840) Fix some UI regressions for commit list (go-gitea#30920) Forbid deprecated `break-word` in CSS (go-gitea#30934) Check if reverse proxy is correctly configured (go-gitea#30890) Remove deprecated stuff for runners (go-gitea#30930)
When a user logout and then login another user, the reverseproxy auth should be checked before session otherwise the old user is still login.