Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support storage base path as prefix #27827

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 29, 2023

This PR adds a prefix path for all minio storage and override base path will override the path.
The previous behavior is undefined officially, so it will be marked as breaking.

Breakage:

This PR will affect all configurations having base_path on storage section but having no base_path on derived storage configuration sections. The base_path on storage will become a prefix for them but not share the same base_path.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 29, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2023
@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 29, 2023
@lunny lunny added this to the 1.22.0 milestone Oct 29, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2023
@lunny lunny added pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Nov 1, 2023
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 1, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 1, 2023
@lunny lunny merged commit d519a39 into go-gitea:main Nov 1, 2023
25 checks passed
@lunny lunny deleted the lunny/support_storage_base_path branch November 1, 2023 11:17
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 1, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 2, 2023
* giteaofficial/main:
  Filter inactive auth sources (go-gitea#27870)
  refactor postgres connection string building (go-gitea#27723)
  doc: actions/act-runner: document running as a systemd service (go-gitea#27844)
  Support storage base path as prefix (go-gitea#27827)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
This PR adds a prefix path for all minio storage and override base path
will override the path.
The previous behavior is undefined officially, so it will be marked as
breaking.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 30, 2024
@delvh
Copy link
Member

delvh commented Apr 4, 2024

@lunny could you please add a paragraph as to how the behavior changed, and what affected users need to do?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants