Add wrapping to long diff lines #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Giving back my LGTM from original PR |
tboerger
added
the
lgtm/need 1
lafriks
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #2789 +/- ##
======================================
Coverage 27.2% 27.2%
======================================
Files 88 88
Lines 17374 17374
======================================
Hits 4726 4726
Misses 11962 11962
Partials 686 686Continue to review full report at Codecov.
|
|
LGTM |
tboerger
added
lgtm/done
vdbt
pushed a commit
to vdbt/gitea
that referenced
this pull request
Oct 27, 2017
* Add wrapping to long diff lines to fix go-gitea#1827 * Fix css class and make changes to source (less) files * Fix wrong space indentation * Fix indentation inconsistencies and remove very old WebKit workaround
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 1, 2019
Wrapping was initially added in go-gitea#2789 but it is currently disabled because the rule that applies wrapping to the wrap class did not have enough CSS specificity. Resolved the issue by using a general selector that matches all code boxes. The previous wrap class was removed because it had only been inconsistenly applied to various code boxes and because I found no easy way to add classes to code boxes rendered in Markdown. Also removed a seemingly useless :before on code view and added padding to restore the spacing.
zeripath
pushed a commit
that referenced
this pull request
Feb 2, 2019
Wrapping was initially added in #2789 but it is currently disabled because the rule that applies wrapping to the wrap class did not have enough CSS specificity. Resolved the issue by using a general selector that matches all code boxes. The previous wrap class was removed because it had only been inconsistenly applied to various code boxes and because I found no easy way to add classes to code boxes rendered in Markdown. Also removed a seemingly useless :before on code view and added padding to restore the spacing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just reopening #1954 as new PR. After unsuccessful rebase&push I can no longer push to @mjwwit branch :(
Fixes #1827