Change default size of issue/pr attachments and repo file

[lng2020]

As title. Some attachments and file sizes can easily be larger than these limits

[silverwind]

How about 50MiB which is also the default on GitHub currently? We do want to find some reasonable default values that prevent abuse from uploading too large files.

Edit: 50 MiB is limit for repo files, but I guess it will work just as well as a reasonable default for attachments etc.

[lng2020]

50MiB is okay for the repo file. But the attachment ->MAX_SIZE is also used in the release page. I think it's better to use a larger one. But we should probably separate the limit of PR/issue attachment and the release file.

[lng2020]

BTW, the alert of the file exceeding limits is broken. Haven't found out root reason yet but it's probably because the function initGlobalDropzone

gitea/web_src/js/features/common-global.js

Lines 199 to 253 in 481e738

	export function initGlobalDropzone() {
	// Dropzone
	for (const el of document.querySelectorAll('.dropzone')) {
	const $dropzone = $(el);
	const _promise = createDropzone(el, {
	url: $dropzone.data('upload-url'),
	headers: {'X-Csrf-Token': csrfToken},
	maxFiles: $dropzone.data('max-file'),
	maxFilesize: $dropzone.data('max-size'),
	acceptedFiles: (['*/*', ''].includes($dropzone.data('accepts'))) ? null : $dropzone.data('accepts'),
	addRemoveLinks: true,
	dictDefaultMessage: $dropzone.data('default-message'),
	dictInvalidFileType: $dropzone.data('invalid-input-type'),
	dictFileTooBig: $dropzone.data('file-too-big'),
	dictRemoveFile: $dropzone.data('remove-file'),
	timeout: 0,
	thumbnailMethod: 'contain',
	thumbnailWidth: 480,
	thumbnailHeight: 480,
	init() {
	this.on('success', (file, data) => {
	file.uuid = data.uuid;
	const input = $(`<input id="${data.uuid}" name="files" type="hidden">`).val(data.uuid);
	$dropzone.find('.files').append(input);
	// Create a "Copy Link" element, to conveniently copy the image
	// or file link as Markdown to the clipboard
	const copyLinkElement = document.createElement('div');
	copyLinkElement.className = 'gt-text-center';
	// The a element has a hardcoded cursor: pointer because the default is overridden by .dropzone
	copyLinkElement.innerHTML = `<a href="#" style="cursor: pointer;">${svg('octicon-copy', 14, 'copy link')} Copy link</a>`;
	copyLinkElement.addEventListener('click', async (e) => {
	e.preventDefault();
	let fileMarkdown = `[${file.name}](/attachments/${file.uuid})`;
	if (file.type.startsWith('image/')) {
	fileMarkdown = `!${fileMarkdown}`;
	} else if (file.type.startsWith('video/')) {
	fileMarkdown = `<video src="/attachments/${file.uuid}" title="${htmlEscape(file.name)}" controls></video>`;
	}
	const success = await clippie(fileMarkdown);
	showTemporaryTooltip(e.target, success ? i18n.copy_success : i18n.copy_error);
	});
	file.previewTemplate.append(copyLinkElement);
	});
	this.on('removedfile', (file) => {
	$(`#${file.uuid}`).remove();
	if ($dropzone.data('remove-url')) {
	POST($dropzone.data('remove-url'), {
	data: new URLSearchParams({file: file.uuid}),
	});
	}
	});
	},
	});
	}
	}

Edited: fixed in #27985

[silverwind]

Right, releases need a separate bigger limit. GitHub has this at 2GB per file currently.