Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: Defined error types for packages maximum count, type size and storage #27977

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2023

Changed errors.New to util.NewInvalidArgumentErrorf when package errors are defined, for simplification of error handling in different package registries.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 9, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2023
@ghost ghost mentioned this pull request Nov 9, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 9, 2023

That's already in #27979?

@ghost
Copy link
Author

ghost commented Nov 9, 2023

@KN4CK3R

Yes, an attempt to make smaller changes with second PR that depend on the first one.
Do I close this one?

@ghost ghost closed this Nov 9, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 9, 2023

Yes, the three lines don't make the other PR complicated.

@ghost ghost deleted the packages-errors-defined-type branch November 10, 2023 00:05
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 8, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants